Issue 100119 - ODFF: Adapt NORMDIST and LOGNORMDIST to definition in odf spec
Summary: ODFF: Adapt NORMDIST and LOGNORMDIST to definition in odf spec
Status: CLOSED FIXED
Alias: None
Product: Calc
Classification: Application
Component: programming (show other issues)
Version: OOo 3.0
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: oc
QA Contact: issues@sc
URL:
Keywords:
Depends on:
Blocks: 69069
  Show dependency tree
 
Reported: 2009-03-11 12:05 UTC by Regina Henschel
Modified: 2017-05-20 11:41 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
The patch is for folder 'formula'. The patch is based on CWS odff06. (1.28 KB, text/plain)
2009-03-25 13:58 UTC, Regina Henschel 		no flags Details
The patch is for folder 'sc'. The patch is based on CWS odff06. (7.51 KB, text/plain)
2009-03-25 13:58 UTC, Regina Henschel 		no flags Details
Testfile for the behavior with optional parameters (16.22 KB, application/vnd.oasis.opendocument.spreadsheet)
2009-03-25 14:00 UTC, Regina Henschel 		no flags Details
Description, how to use the test file (1.96 KB, text/plain)
2009-03-25 14:08 UTC, Regina Henschel 		no flags Details
testcase using decimal point as separator (16.33 KB, application/vnd.oasis.opendocument.spreadsheet)
2009-04-29 23:14 UTC, ooo 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Regina Henschel 2009-03-11 12:05:16 UTC 
The forth parameter in NORMDIST is optional.
LOGNORMDIST has a forth parameter to calculate the density function. The second,
third, and forth parameter are optional.

I'll work on it. If that is OK, please assign issue to me.
Comment 1 ooo 2009-03-11 13:00:02 UTC 
Yes, sure, of course, thanks :-)
Comment 2 Regina Henschel 2009-03-25 13:58:02 UTC 
Created attachment 61177 [details]
The patch is for folder 'formula'. The patch is based on CWS odff06.
Comment 3 Regina Henschel 2009-03-25 13:58:58 UTC 
Created attachment 61178 [details]
The patch is for folder 'sc'. The patch is based on CWS odff06.
Comment 4 Regina Henschel 2009-03-25 14:00:18 UTC 
Created attachment 61179 [details]
Testfile for the behavior with optional parameters
Comment 5 Regina Henschel 2009-03-25 14:08:16 UTC 
Created attachment 61181 [details]
Description, how to use the test file
Comment 6 Regina Henschel 2009-03-25 14:13:03 UTC 
Hi Eike, here are the patches, now based on CWS odff06. I have attached a file
for testing the optional parameters in addition. This patch includes an
improvement of the accuracy and so solves the 'Normsdist'-part in issue 69069.
Comment 7 ooo 2009-04-29 23:12:32 UTC 
In cws odff06:

revision 271395
formula/source/core/api/token.cxx
sc/source/core/inc/interpre.hxx
sc/source/core/tool/interpr3.cxx
sc/source/filter/excel/xeformula.cxx
sc/source/ui/src/scfuncs.src

Nice testcase :-)  It has some localization problem though, as the textual
formula strings use a comma as decimal separator. If loaded in a locale with a
different separator the checks don't match. Either one has to switch to a locale
that uses a comma, e.g. de-DE German_Germany, before loading or after load and
then change any cell so the =FORMULA(...) calls get updated; or the other
possibility is to use the file I'll attach where I replaced the separators in
content.xml.

In any case, the textual function names expect an English UI; for a different UI
one might try to set the environment variable OOO_CALC_USE_ENGLISH_FORMULAS=Yes
prior to running the office to force that and then load the modified testcase
document.
Comment 8 ooo 2009-04-29 23:14:33 UTC 
Created attachment 61901 [details]
testcase using decimal point as separator
Comment 9 ooo 2009-09-03 16:34:11 UTC 
Reassigning to QA for verification.
Comment 10 oc 2009-09-10 14:49:51 UTC 
verified in internal build cws_odff06