Issue 100275 - Make impress table copy hard formatings from last row for new rows
Summary: Make impress table copy hard formatings from last row for new rows
Status: CONFIRMED
Alias: None
Product: Impress
Classification: Application
Component: code (show other issues)
Version: recent-trunk
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-17 15:54 UTC by thb
Modified: 2017-05-20 11:08 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
Proposed fix (5.03 KB, patch)
2009-03-17 15:54 UTC, thb
no flags Details | Diff
Better fix (624 bytes, patch)
2009-03-19 16:18 UTC, thb
no flags Details | Diff
Bugdoc (109.50 KB, application/vnd.ms-powerpoint)
2009-03-19 16:19 UTC, thb
no flags Details
fixing FuTable instead (1.07 KB, patch)
2009-05-14 14:54 UTC, thb
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description thb 2009-03-17 15:54:03 UTC
See $subject. For empty rows, it seems ppt takes the row height from the table
properties, and does not assume default font minimal height. Fix attached.
Comment 1 thb 2009-03-17 15:54:53 UTC
Created attachment 60990 [details]
Proposed fix
Comment 2 sven.jacobi 2009-03-18 19:16:49 UTC
sj->thb: Are you having a test document, because I doubt that the cell row
height from table properties differ from the height that is being calculated by
the shapes, this would prevent backward compatibility to PowerPoint 97 as PPT97
is not knowing anything about table properties. 
Comment 3 thb 2009-03-19 16:18:35 UTC
Created attachment 61050 [details]
Better fix
Comment 4 thb 2009-03-19 16:19:25 UTC
Created attachment 61051 [details]
Bugdoc
Comment 5 thb 2009-03-19 16:21:45 UTC
@sj: yeah, good catch, poked cell height too late; the actual root cause is the
minimal font height enforced during layout. Much simpler patch attached.
Comment 6 sven.jacobi 2009-03-19 18:00:12 UTC
thanks a lot, the patch has been applied to cws[impress169].
Comment 7 sven.jacobi 2009-05-05 15:43:44 UTC
sj->wg: this issue is ready to be verified in cws[impress169]
Comment 8 clippka 2009-05-13 14:38:24 UTC
proposed fix breaks default layouting behavior. Correct fix would be to use the
row height (if set) as a minimum height if no text is given in that row
Comment 9 sven.jacobi 2009-05-13 14:46:43 UTC
sj->cl: This issue will be removed from cws[impress169] by wg and needs to be
fixed elsewhere, I give this issue into your hands..
Comment 10 thb 2009-05-14 14:53:08 UTC
@cl: not at all. if you're still talking about table creation - then there is no
row height set. The culprit seems DrawViewShell::FuTable()'s slightly simplistic
aSize settings, attaching a rough patch for fixing that restores old behaviour
(though I _probably_ would just bump up aSize's height to something looking
good, after all the width is also not adapting to the number of columns...)
Comment 11 thb 2009-05-14 14:54:47 UTC
Created attachment 62267 [details]
fixing FuTable instead
Comment 12 clippka 2009-06-04 14:43:43 UTC
retarget
Comment 13 sven.jacobi 2009-06-17 11:22:00 UTC
setting target to OOo 3.2 because of 159150
Comment 14 clippka 2009-09-08 18:09:25 UTC
retargeted
Comment 15 clippka 2010-06-07 12:06:38 UTC
after having a second look at the attached bugdoc I'm not sure what the core
issue is here. When loaded in a dev300m80 the document looks exactly as when
loaded in PowerPoint 2010 (there is an problem with the gradient but thats
another issue).

The difference comes when adding new lines to the table. PowerPoint copies the
formating of the last table. Impress uses the table style to format the next line.

So in my opnion the real fix for this issue would be to copy hard formatings
from the current line to newly created lines. Which  will be most times whats
the user expects and if not it can be fixed by applying the table style again.
Comment 16 Marcus 2017-05-20 11:08:26 UTC
Reset assigne to the default "issues@openoffice.apache.org".