Apache OpenOffice (AOO) Bugzilla – Issue 100275
Make impress table copy hard formatings from last row for new rows
Last modified: 2017-05-20 11:08:26 UTC
See $subject. For empty rows, it seems ppt takes the row height from the table properties, and does not assume default font minimal height. Fix attached.
Created attachment 60990 [details] Proposed fix
sj->thb: Are you having a test document, because I doubt that the cell row height from table properties differ from the height that is being calculated by the shapes, this would prevent backward compatibility to PowerPoint 97 as PPT97 is not knowing anything about table properties.
Created attachment 61050 [details] Better fix
Created attachment 61051 [details] Bugdoc
@sj: yeah, good catch, poked cell height too late; the actual root cause is the minimal font height enforced during layout. Much simpler patch attached.
thanks a lot, the patch has been applied to cws[impress169].
sj->wg: this issue is ready to be verified in cws[impress169]
proposed fix breaks default layouting behavior. Correct fix would be to use the row height (if set) as a minimum height if no text is given in that row
sj->cl: This issue will be removed from cws[impress169] by wg and needs to be fixed elsewhere, I give this issue into your hands..
@cl: not at all. if you're still talking about table creation - then there is no row height set. The culprit seems DrawViewShell::FuTable()'s slightly simplistic aSize settings, attaching a rough patch for fixing that restores old behaviour (though I _probably_ would just bump up aSize's height to something looking good, after all the width is also not adapting to the number of columns...)
Created attachment 62267 [details] fixing FuTable instead
retarget
setting target to OOo 3.2 because of 159150
retargeted
after having a second look at the attached bugdoc I'm not sure what the core issue is here. When loaded in a dev300m80 the document looks exactly as when loaded in PowerPoint 2010 (there is an problem with the gradient but thats another issue). The difference comes when adding new lines to the table. PowerPoint copies the formating of the last table. Impress uses the table style to format the next line. So in my opnion the real fix for this issue would be to copy hard formatings from the current line to newly created lines. Which will be most times whats the user expects and if not it can be fixed by applying the table style again.
Reset assigne to the default "issues@openoffice.apache.org".