Issue 101372 - Slide show updates canvas twice per frame
Summary: Slide show updates canvas twice per frame
Status: CONFIRMED
Alias: None
Product: Impress
Classification: Application
Component: code (show other issues)
Version: DEV300m45
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-27 13:09 UTC by groucho266
Modified: 2017-05-20 11:08 UTC (History)
1 user (show)

See Also:
Issue Type: ENHANCEMENT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description groucho266 2009-04-27 13:09:03 UTC
In SlideShowImpl::update() there are two calls to
maScreenUpdater.commitUpdates().  In some cases this can lead to two updates of
the canvas and thereby almost doubling the time it takes to render each frame.
One such case is per-characte animation of text.

Reduce this to just one call to commitUpdates().
Comment 1 groucho266 2009-04-27 13:24:31 UTC
The second call to commitUpdates() is made for two reasons:

1) The last step in an animation is not done like the other steps by calling
perform() on the activity object from ActivitiesQueue::process.  For performance
reasons it is done after the activity has been removed from the queue in
ActivitiesQueue::processDequeued().  Also the last step is not painted by use of
sprites but by painting the animated sprite in its final configuration directly
to the canvas.

2) Hiding or showing the wait symbol also leads to update of the canvas.  That
update, however, is not properly synchronized with the display of animated
shapes and thus can lead to the display of intermediate shape states.


Possible solution:
Regarding 1) can maybe be solved by keeping every activity alive one more frame.
 The last step in the animation is performed like every other step before. 
Before the sprite is removed the shape is painted in its new configuration. 
Only after that the activity is deactivated and the sprite is removed.
Comment 2 groucho266 2009-09-25 09:27:07 UTC
Changing target to OOo 3.3.
Comment 3 groucho266 2010-07-07 15:43:54 UTC
Changing target due to time constraints.
Comment 4 groucho266 2011-02-08 16:10:40 UTC
Changing target.
Comment 5 Marcus 2017-05-20 11:08:25 UTC
Reset assigne to the default "issues@openoffice.apache.org".