Issue 103770 - tools/workben/solar.c: missing call to fclose
Summary: tools/workben/solar.c: missing call to fclose
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: code (show other issues)
Version: OOo 3.1
Hardware: All All
: P5 (lowest) Trivial (vote)
Target Milestone: OOo 3.3
Assignee: caolanm
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks: 106602
  Show dependency tree
 
Reported: 2009-07-24 10:16 UTC by dcb314
Modified: 2009-11-05 20:48 UTC (History)
2 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
add fclose (490 bytes, patch)
2009-07-28 06:35 UTC, dtardon 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description dcb314 2009-07-24 10:16:40 UTC 
For the source code file tools/workben/solar.c,
around line 340 is the source code

  FILE* f = fopen( name, "w" );

I can't see a matching call to fclose, so this looks
like a memory leak to me. Suggest add call, to close
the leak.
Comment 1 caolanm 2009-07-24 11:01:04 UTC 
reassigning to more appropriate owner. Fairly minor as its on a workben scratch
project
Comment 2 dtardon 2009-07-28 06:35:09 UTC 
No harm in fixing that, I guess. There is also a call to exit() that can safely
be removed, for return stmt (that is there anyway) will serve just as well.
Comment 3 dtardon 2009-07-28 06:35:54 UTC 
Created attachment 63814 [details]
add fclose
Comment 4 caolanm 2009-10-30 21:57:11 UTC 
while I'm at it, I'll take this related low hanger
Comment 5 caolanm 2009-10-31 11:55:43 UTC 
hmm, actually already integrated in mh132, mh must have forgot to cws task it to
the workspace, but its already in there
Comment 6 caolanm 2009-10-31 11:55:58 UTC 
mh132