Issue 104293 - Toggle-able buttons should be exposed as ROLE_TOGGLE_BUTTON
Summary: Toggle-able buttons should be exposed as ROLE_TOGGLE_BUTTON
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: DEV300m51
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 3.3
Assignee: eric.savary
QA Contact: issues@framework
URL:
Keywords: accessibility
Depends on:
Blocks:
 
Reported: 2009-08-17 16:39 UTC by joaniediggs
Modified: 2010-06-23 12:18 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description joaniediggs 2009-08-17 16:39:08 UTC
Steps to reproduce:

1. Launch Writer and Accerciser.

2. Use Accerciser to examine the toggle-able/check-able buttons in the Standard
and Formatting toolbars (e.g. AutoSpellcheck, Bold, Numbering, etc. etc.)

Expected results: Toggle-able buttons would be exposed as ROLE_TOGGLE_BUTTON

Actual results: Toggle-able buttons are exposed as ROLE_PUSH_BUTTON, just like
(nearly) all of the other buttons on these toolbars.

Impact: Orca cannot distinguish a button which is off/untoggled from other,
non-toggle-able push buttons (new, save, print, etc.). As a result, Orca has
three options:

1. Say "off" for all toolbar push button which lacks STATE_CHECKED (current
behavior, results in "off" being spoken when it shouldn't as the user explores
toolbars).

2. Never say "off" for toolbar push buttons (Users might get confused and think
bold is on when it isn't really.)

3. Try to cleverly guess which push buttons are really toggle buttons and which
are not. (Given localization issues, the ability to move and customize toolbars,
etc., this really isn't a reliable option.)

Therefore, it would be awesome if you could change how these objects are exposed
to us. Thanks!
Comment 1 joaniediggs 2009-08-17 16:41:34 UTC
.
Comment 2 eric.savary 2009-12-16 16:02:57 UTC
@OS: it looks like a general UI change need in the whole office.
Setting MT and AB on CC in case you wouldn't be responsible for this.
Comment 3 Oliver Specht 2010-01-11 14:56:08 UTC
The A11Y wrapper of toolboxes in 
accessibility/source/standard/vclxaccessibletoolboxitem.cxx
takes care for toggle buttons which have the related flags set (TIB_CHECKABLE or
TIB_AUTOCHECK)

The application toolbox items don't have the flags set. Their toggle-ability is
implemented by framework logic. 
Reassigned to cd
Comment 4 carsten.driesner 2010-05-06 17:12:29 UTC
cd: Added enhancement to store the context data what commands have a toggle state.
Comment 5 carsten.driesner 2010-05-11 09:54:00 UTC
cd->es: Please verify.
Comment 6 eric.savary 2010-05-12 17:13:12 UTC
@CD: looking at the description, it's a fixed but failed for some toggle buttons
(just had a look at Formatting and Standard toolbars) are still exposed as push
buttons though they are toggle buttons:
Formatting:
- Numbering On/Off
- Bulletts On/Off

Standard:
- Edit File
- Format Paintbrush
- Hyperlink
- Data Sources
- Nonprinting Characters

No doubt that other toolbars have this problem too.
Comment 7 eric.savary 2010-05-12 18:06:25 UTC
Reassigned
Comment 8 carsten.driesner 2010-05-18 13:50:17 UTC
cd->es: I updated all the commands that you have found so far. The type of a
button is determined by the implementation therefore it's a time consuming to
complete this issue. Please have a look and provide information if you will find
more commands.
Comment 9 carsten.driesner 2010-05-18 16:36:55 UTC
cd->es: Please verify again.
Comment 10 eric.savary 2010-05-19 13:30:44 UTC
Verified in CWS fwk242

@joanie: as CD mentioned, we have now applied the correct role to the most
common toggle button. A fix in depth would be to identify every toggle button in
the whole program and to affect the correct role, one by one. This is a huge work.
If you want, file another for this.
Comment 11 malte_timmermann 2010-06-23 12:18:44 UTC
Closing accessibility issues which have been fixed, verified and integrated...