Apache OpenOffice (AOO) Bugzilla – Issue 104788
framework::DropdownToolbarController: dispatch does not get selected item text
Last modified: 2017-05-20 10:30:52 UTC
As reported by Krzysztof RÄ…czkiewicz at dev@api.openoffice.org http://api.openoffice.org/servlets/BrowseList?list=dev&by=thread&from=2275837 framework::DropdownToolbarController does not send the selected text to the dispatch object. Root cause is the method used to retrieve the text from the ListBox http://svn.services.openoffice.org/opengrok/xref/DEV300_m56/framework/source/ui it should be ListBox::GetSelectEntry()
Created attachment 64545 [details] dropdownboxtoolbarcontroller.cxx fix
These bug is two years old. Really a shame. Taking ownership. Started.
Created attachment 76921 [details] Updated patch
Created attachment 76922 [details] Complex Toolbar Controls Extension from the SDK Among other small clean up, the patch adds code to get the selected item text. * Build the extension with DEBUG=yes. * Try the extension without applying the patch in the framework module * The terminal output should look like: Trace 13674/1: "Dropdownbox control - selected entry text : " Trace 13674/1: "Dropdownbox control - selected entry text : " Trace 13674/1: "Dropdownbox control - selected entry text : " Trace 13674/1: "Dropdownbox control - selected entry text : " The dispatch does not get the selected text. * Apply the patch in the framework module and try the extension * The output should display the selected entry text: Trace 13815/1: "Dropdownbox control - selected entry text : Blue" Trace 13815/1: "Dropdownbox control - selected entry text : Orange" Trace 13815/1: "Dropdownbox control - selected entry text : Black" Trace 13815/1: "Dropdownbox control - selected entry text : Pink"
Created attachment 76929 [details] Complex Toolbar Controls Extension from the SDK
I committed the first patch as revision 1189574. The second patch appears to be malformed: Patching file odk/examples/cpp/complextoolbarcontrols/MyListener.cxx using Plan A... patch: **** malformed patch at line 354: @@ -57,12 +50,12 @@ css::uno::Any SAL_CALL MyListener::execute(const css::uno::Sequence< css::beans: [
Created attachment 76935 [details] Complex Toolbar Controls Extension from the SDK
(In reply to comment #6) > I committed the first patch as revision 1189574. > > The second patch appears to be malformed: > > Patching file odk/examples/cpp/complextoolbarcontrols/MyListener.cxx using Plan > A... > patch: **** malformed patch at line 354: @@ -57,12 +50,12 @@ css::uno::Any > SAL_CALL MyListener::execute(const css::uno::Sequence< css::beans: > [ please try the new version (though I'm not sure what the error can be, I run diff between v2 and v3 of the patch, and they are the same, no diffence at all).
I think the problem was GNU diff/patch. svn commit -m "i104788 - Complex Toolbar Controls Extension from the SDK" Sending odk/examples/cpp/complextoolbarcontrols/Addons.xcu Sending odk/examples/cpp/complextoolbarcontrols/ListenerHelper.h Sending odk/examples/cpp/complextoolbarcontrols/Makefile Sending odk/examples/cpp/complextoolbarcontrols/MyJob.cxx Sending odk/examples/cpp/complextoolbarcontrols/MyJob.h Sending odk/examples/cpp/complextoolbarcontrols/MyListener.cxx Sending odk/examples/cpp/complextoolbarcontrols/MyListener.h Sending odk/examples/cpp/complextoolbarcontrols/MyProtocolHandler.cxx Sending odk/examples/cpp/complextoolbarcontrols/MyProtocolHandler.h Sending odk/examples/cpp/complextoolbarcontrols/exports.cxx Transmitting file data .......... Committed revision 1190390. Thanks!