Issue 105449 - oox: build fails because of missing include
Summary: oox: build fails because of missing include
Status: CLOSED DUPLICATE of issue 105219
Alias: None
Product: xml
Classification: Code
Component: code (show other issues)
Version: DEV300m60
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: daniel.rentz
QA Contact: issues@xml
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-29 13:59 UTC by dtardon
Modified: 2009-09-29 14:17 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
call gperf with --includes (854 bytes, patch)
2009-09-29 13:59 UTC, dtardon 		no flags Details | Diff
#include <cstring> where needed (401 bytes, patch)
2009-09-29 14:00 UTC, dtardon 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description dtardon 2009-09-29 13:59:17 UTC 
There is strncmp used in tokens.inc (output of gperf), but the corresponding
header file is not included. There are two possible fixes: call gperf with
--includes or add #include <cstring> to tokenmap.cxx, where tokens.inc itself is
included. I prefer the latter one, because tokens.inc is included inside of a
default namespace and including std. stuff, even if it's "just" C, to other
namespace doesn't sound right.
Comment 1 dtardon 2009-09-29 13:59:56 UTC 
Created attachment 65036 [details]
call gperf with --includes
Comment 2 dtardon 2009-09-29 14:00:25 UTC 
Created attachment 65037 [details]
#include <cstring> where needed
Comment 3 daniel.rentz 2009-09-29 14:16:17 UTC 
double and already fixed

*** This issue has been marked as a duplicate of 105219 ***
Comment 4 daniel.rentz 2009-09-29 14:17:15 UTC 
closed