Issue 105508 - Text in cell is only completly visible in edit mode
Summary: Text in cell is only completly visible in edit mode
Status: CLOSED FIXED
Alias: None
Product: Impress
Classification: Application
Component: viewing (show other issues)
Version: DEV300m60
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 3.2
Assignee: wolframgarten
QA Contact: issues@graphics
URL:
Keywords: regression
: 105208 (view as issue list)
Depends on:
Blocks: 99999
  Show dependency tree
 
Reported: 2009-10-01 10:50 UTC by clippka
Modified: 2010-02-08 17:13 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Bugdoc with invisible text in cell (14.71 KB, application/vnd.oasis.opendocument.presentation)
2009-10-01 10:58 UTC, clippka 		no flags Details
Proposed patch for fixing this task (15.44 KB, text/plain)
2009-10-02 13:10 UTC, Armin Le Grand 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description clippka 2009-10-01 10:50:38 UTC 
Open attached bugdoc, there is a table with only one cell (for simplification,
the original table had more cells). The text is a one liner. Click into the text
and you see that the text is actuall 3 lines

This is both a (visual) data loss and also a security issue (hidden data)
Comment 1 clippka 2009-10-01 10:58:12 UTC 
Created attachment 65073 [details]
Bugdoc with invisible text in cell
Comment 2 clippka 2009-10-01 11:18:35 UTC 
adding regression keyword as this worked in OOo 3.1
Comment 3 Armin Le Grand 2009-10-01 13:46:46 UTC 
AW: Strange, works well on my current CWS (aw078, DEV300 m57). Need to get the
CWS impoess 177, then...
Comment 4 Armin Le Grand 2009-10-01 16:52:57 UTC 
AW: Found no difference yet between DEV300 m60 and DEV300 m57. When i replace
the text from the BugDoc with typing text, i GET it layouted as block (as
wanted), so it might have to do wit the existing text somehow. It definitely has
to do with the Outliner, it just does something else with the original text...
Comment 5 Armin Le Grand 2009-10-01 17:01:52 UTC 
AW: Checked ControlWord, FixedCellHeight flag and AnchorTextSize, all are the
same between original and self-typed text. This hints that the difference
may/should be in the OPO itself. I will need to debug the Outliner's text
layouting...
Comment 6 Armin Le Grand 2009-10-01 17:52:30 UTC 
AW: Found. The text portions get clipped away during primitive clipping in
impDecomposeBlockTextPrimitive. It was added by CWS impress174 from SJ,
supported by me. Aim was to clip text for AutoShapes
(SdrCustomShapePrimitive2D). Since there already existed a CellText flag at the
SdrBlockTextPrimitive2D and the cell text also needs to be clipped (and
AutoShape and Cell texts are layouted the same), this flag is used.

The clipping itself is very exact: A text portion is only accepted when it is
completely inside the given ClipRange (the text frame in case of cell text and
AutoShapes).

It's so exact that the text in the exampe is NOT completely inside since it's
italic. When switching italic off, the text is shown as intended.

Thus, the idea for a fix is pretty straightforward: For getting the range of the
text portion, do use the current font, but remove italic and fat attributes first...
Comment 7 Armin Le Grand 2009-10-02 13:09:26 UTC 
AW: Added own flag for ClipOnBounds to SdrBlockTextPrimitive2D and the helper
createTextPrimitive; adapted usages; corrected VerticalText stuff; corrected
ClipOnBounds for CustomShapes.
AW: Checked in, done. Changes are in SVX only and compatible. I'll add a diff
describing the change, too.
Comment 8 Armin Le Grand 2009-10-02 13:10:11 UTC 
Created attachment 65096 [details]
Proposed patch for fixing this task
Comment 9 clippka 2009-10-07 16:51:50 UTC 
verified in cws, back to qa
Comment 10 wolframgarten 2009-10-09 12:03:31 UTC 
Verified in CWS.
Comment 11 clippka 2009-10-16 10:29:42 UTC 
*** Issue 105208 has been marked as a duplicate of this issue. ***
Comment 12 Raphael Bircher 2010-02-08 17:13:51 UTC 
Tested with 3.2.0 on Mac OS X 10.5.x, works fine

Closing issue