Issue 105543 - framework: unused UIConfigurationManagerImpl::getEventsManager
Summary: framework: unused UIConfigurationManagerImpl::getEventsManager
Status: CLOSED NOT_AN_OOO_ISSUE
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: DEV300m60
Hardware: All Linux, all
: P3 Trivial (vote)
Target Milestone: OOo 3.3
Assignee: carsten.driesner
QA Contact: issues@framework
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-02 11:40 UTC by caolanm
Modified: 2009-11-24 15:52 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
version one, use it (529 bytes, patch)
2009-10-02 11:41 UTC, caolanm 		no flags Details | Diff
version two, lose it (1.95 KB, patch)
2009-10-02 11:42 UTC, caolanm 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description caolanm 2009-10-02 11:40:58 UTC 
UIConfigurationManagerImpl::getEventsManager is unused. Presumably it should
either get used like the rest of the impl methods, or removed. In this
particular case either option gives the exact same results, so just a matter of
taste.
Comment 1 caolanm 2009-10-02 11:41:25 UTC 
Created attachment 65087 [details]
version one, use it
Comment 2 caolanm 2009-10-02 11:42:18 UTC 
Created attachment 65088 [details]
version two, lose it
Comment 3 Mathias_Bauer 2009-10-02 13:28:00 UTC 
carsten, please take over
Comment 4 carsten.driesner 2009-10-02 13:37:05 UTC 
cd->cmc: Thanks for the patch Coalan. Currently I had to revert the changes
introduced by oj18 due to too much regressions. I will apply your patch when I
reworked the changes from obj18.
Comment 5 carsten.driesner 2009-10-02 13:37:22 UTC 
cd: Set to OOo 3.3.
Comment 6 caolanm 2009-10-20 19:57:54 UTC 
This particular code is gone in m62, so if the code isn't coming back it could
be closed out.
Comment 7 carsten.driesner 2009-11-10 09:01:06 UTC 
cd: Review with mav revealed several problems in the changes made by oj18.
Therefore I will leave the current code intact. As this patch fixes code which
is not inside the source tree I have to close this issue as invalid.

cd->cmc: Thanks for you work. Unfortunately I have to close this issue with your
patch. The reworked code had several issues and I decided to activate the old
and correct code again.
Comment 8 Mechtilde 2009-11-24 15:52:49 UTC 
invalid -> closed