Issue 106854 - Document recovery leads to conflict by saving recovered files
Summary: Document recovery leads to conflict by saving recovered files
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: OOO320m4
Hardware: Unknown Windows XP
: P3 Trivial (vote)
Target Milestone: OOo 3.2
Assignee: thorsten.martens
QA Contact: issues@framework
Depends on:
Blocks: 99999
  Show dependency tree
Reported: 2009-11-12 12:35 UTC by cno
Modified: 2017-05-20 10:29 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Note You need to log in before you can comment on or make changes to this issue.
Description cno 2009-11-12 12:35:41 UTC
After a crash
- First a save occures
- Then the recovery starts
- Then, for various files, when closing, it is asked whether they have 
  to be saved
- Choosing Yes, will leed to the following question

 = = = = = = = = = = = = 
 "Document Has Been Changed By Others"
 | ?  The file has been changed since it was opened for editing in 
      OOo-dev. Saving your version of the document will overwrite 
      changes made by others.

      Do you want to save anyway?

      |   Save anyway   |   Cancel   |
 = = = = = = = = = = = = 

Have seen this various times. I think (pretty sure) only in 3.2-dev versions.
Comment 1 cno 2009-11-18 12:05:40 UTC
Additional PITA:
With a Calc document, after choosing 'Save anyway' the following appears:

 = = = = = = = = = = = = 
 "OOo-dev 3.2"
  X | Error saving the document <name>:
      Write error.
      The file could not be written.
       |   OK    |
 = = = = = = = = = = = = 

Then saving for the second time, this stop message does not apprear...
Comment 2 Mathias_Bauer 2009-11-18 13:09:19 UTC
To make sure that I understand that correctly:
The recovery started immediately after the emergency save and OOo alleged that
the original file is modified. *Is* the original file modified? Can you exclude
that somebody else has modified the file after you have opened it, especially
after OOo has crashed?
Comment 3 cno 2009-11-18 13:18:41 UTC
@mathias: Yes, all steps take place immediately after the previous.
And all files are local.

Good way to test (for me) in m4: 
with some documents open, open the dialog "Bullets and Numbering" and click
Options tab. (now it crashes already when trying to open the dialog. Will send
the reportID when I receive it).
Comment 4 Mathias_Bauer 2009-11-18 14:01:22 UTC
@tm: please try to reproduce the problem. If we can reproduce it, it would be a
candidate for a showstopper.
Comment 5 thorsten.martens 2009-11-18 16:03:54 UTC
I'm unable to reproduce the problem. I used an OOo320m4 build on WinXP and let
the office crash in the mentioned way (bullets and numbering). Everything works
as exspected (document recovery and crashreporter) and no additional warnings or
errors occured. Closing the recovered documents afterwards worked also without
Comment 6 niklas.nebel 2009-11-18 16:47:47 UTC
I can reproduce it. Recovery works, but the error occurs when saving the
recovered file (it must have been modified before the crash).
Comment 7 cno 2009-11-18 19:56:42 UTC
@nn: thanks for confriming
Saves me searching for "strange local circumstances @cor" ;-)
Comment 8 Mathias_Bauer 2009-11-19 07:44:57 UTC
Mikhail, please take over. IMHO this deserves to become a showstopper. Cor,
could you write a request?
Comment 9 mikhail.voytenko 2009-11-19 08:38:46 UTC
Comment 10 thorsten.martens 2009-11-19 08:52:49 UTC
Now, with the additional info, I can also reproduce this behaviour !


- create new document
- edit document
- save document
- edit again
- let office crash (simply by using bullets and numbering/options)
- let office recover
- click on save-button after office has restarted

-> message appears !
Comment 11 mikhail.voytenko 2009-11-19 12:42:22 UTC
The first dialog appears because of wrong time stamp check. The original file
has to be checked instead of recovery version.
The framework part of the fix is commited in fwk129.
Comment 12 uwe.luebbers 2009-11-19 14:42:45 UTC
set target
Comment 13 niklas.nebel 2009-11-19 15:42:53 UTC
The Calc change for the second error is also in fwk129.
Comment 14 mikhail.voytenko 2009-11-19 15:44:18 UTC
Setting to fixed since the Calc part of the fix is also commited to fwk129.
Comment 15 mikhail.voytenko 2009-11-24 10:26:39 UTC
mav->tm: Please verify the issue.
Comment 16 thorsten.martens 2009-12-02 11:56:24 UTC
Checked and verified in cws fwk129 -> OK !