Apache OpenOffice (AOO) Bugzilla – Issue 108009
Edit and Insert icons and menu items shold always be greyed out if operation is impossible because of cell protection
Last modified: 2013-01-29 21:48:40 UTC
setting the cell cursor inside an unprotected cell of a protected sheet will activate the commands "insert rows/colmuns". but if one tries to insert a row/column an error message is displayed (see picture 1_protected_sheet_insert_rows_columns_activated.gif) after inserting a comment (for example) the commands for deleting rows/columns are activated too. if one tries to delete a row/columns an error message is displayed. (see picture 2_protected_sheet_insert_delete_rows_columns_activated) setting the cell cursor to a protected cell will deactivate the commands "insert rows/columns" but not the commands for deleting rows/columns. (see picture 3_protected_sheet_delete_rows_columns_activated) please have a look at the attachment's
Created attachment 66915 [details] 1_protected_sheet_insert_rows_columns_activated
Created attachment 66916 [details] 2_protected_sheet_insert_delete_rows_columns_activated
Created attachment 66917 [details] 3_protected_sheet_delete_rows_columns_activated
Indeed, currently the menu items and icons are greyed out only if the cell cursor (or selection) is on a protected cell, but not, if a cell "in the neighbourhood will make the offered operation impossible. Example with my "sample.odt": Icons in Insert Cell Toolbar will only be greyed out if cell cursor is on a protected cell, but not, if 'F12' is selected, where also all 'insert cell' operations are impossible because of protected cell 'G13'. Also context menus are affected. I believe it might be useful that always only possible operations will be shown as active, and it should not be too difficult to integrate that function, because the protection always works if you try to start a forbidden action. But it might cost some performance if OOo always has to calculate for each new cell cursor position what actions will be allowed?
Created attachment 66930 [details] Sample document
>But it might cost some performance if OOo always has to >calculate for each new cell cursor position what actions will be allowed? mh, maybe i am wrong, but imho insert rows/columns should never be possible if the current sheet is proteced - so only a sheetChangeListener would be necessary to de/activate the toolbar commands ?