Issue 108349 - build performance issue when writing .rdb file
Summary: build performance issue when writing .rdb file
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: code (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: hjs
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-15 13:09 UTC by hjs
Modified: 2013-08-07 15:34 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description hjs 2010-01-15 13:09:34 UTC 
the fix for #i105360# unfortunately had massive impact on the build performance
for all modules writing .rdb files (udkapi, offapi and more).
Comment 1 matthias.huetsch 2010-02-16 14:42:43 UTC 
Accepting, will be fixed on cws mhu22 ...
Comment 2 matthias.huetsch 2010-03-12 11:29:29 UTC 
Fixed on cws mhu22.

[Registry keys are now better refcounted, so that 'release()' (and destruction)
can be distinguished from explicit 'close()', where the underlying rdb can then
be flush()'d.]
Comment 3 matthias.huetsch 2010-03-12 11:30:29 UTC 
Hi Ause,

As you already work with this fix, can you please verify this issue ?

Thanks,
Matthias
Comment 4 matthias.huetsch 2010-03-12 12:14:31 UTC 
hmm, forgot to reassign ...
Comment 5 hjs 2010-03-18 16:52:45 UTC 
i dug out some old milestones and checked the build times of offapi in a local
windows build:

DEV300m61, before extra flushing the .rdb: ~8 min.
DEV300m63, right after the flushing was implemented: ~12 min.
DEV300m75, some flushes removed: ~10 min.
mhu22: ~7 min.

so we're even faster than before with the new implementation.
Comment 6 hjs 2010-04-15 11:20:35 UTC 
.