Issue 108450 - For lines return a matrix with rotation in the API
Summary: For lines return a matrix with rotation in the API
Status: CLOSED WONT_FIX
Alias: None
Product: *Testproduct
Classification: Test
Component: code (show other issues)
Version: DEV300m69
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 3.3
Assignee: Armin Le Grand
QA Contact: issues@test
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-19 12:21 UTC by Armin Le Grand
Modified: 2010-02-02 19:16 UTC (History)
2 users (show)

See Also:
Issue Type: ENHANCEMENT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description Armin Le Grand 2010-01-19 12:21:19 UTC
AW: SdrPathObj::TRGetBaseGeometry returns a correct combination for lines, wiich
is the rotated line geometry and the matrix containing translate and scale. It
would be better to have the rotaiton in the matrix, not in the line polygon.
Thus, better return a unit line along the X-Axis and the rotation as part of the
matrix.
Comment 1 Armin Le Grand 2010-01-19 12:23:58 UTC
AW: Changed type
Comment 2 Regina Henschel 2010-01-19 18:43:00 UTC
add me to CC
Comment 3 Armin Le Grand 2010-02-01 14:04:07 UTC
AW: Started, changed SdrPathObj::TRGetBaseGeometry (and
SdrMeasureObj::TRGetBaseGeometry, too). It can be done quite simple in
TRGetBaseGeometry, but it has immediate consequences for XMLOFF shape
exprt/import. Lines are no longer correctly loaded/saved when doing this.

It is possible to adapt the needed places in XMLOFF, but in principle doing this
consequently would lead to writing lines not as start and end point (as now),
but as horizontal lines starting from (0,0) to (length, 0) and with rotation and
translation in a matrix statement, analog to rotated other objects.

This makes it bad human readable, unsafe for older imports of OOo and other
usages of ODF from other users.

With this knowledge and the fact that this is not an error but just an
enhancement, i opt to not do it. Everyone getting the geometry and matrix using
TRGetBaseGeometry can extract the rotation and add to the matrix if he wants.
Comment 4 Armin Le Grand 2010-02-01 14:05:39 UTC
AW: Setting to wontfix (for enhancement, there should be a WONTCHANGE).
Comment 5 Mechtilde 2010-02-02 19:16:57 UTC
wontfix -> closed