Created attachment 68042 [details]
Scrollbar not restored after reopening doc / restarting OOo

set keyword

please try to fix for 3.3

I can't reproduce this...

This happens when the new window is opened in maximized state and has view
settings that don't fit into the non-maximized size. In 3.2, the window is
temporarily resized to the smaller size, and the view settings are adjusted to
that size. It affects not only the size of the TabBar, but also things like
split views (issue 111104).

*** Issue 111104 has been marked as a duplicate of this issue. ***

This originates in a duplicate SetWIndowState, the second one happens when the
window is already visible and causes the issue.

@cd: thanks for taking over

cd: The following stack traces show how SetWindowState is called.

1. Call
-------
#0  SystemWindow::SetWindowState (this=0xef7e572c, rStr=...)
    at /export/home/pl/vcl111/ooo/vcl/source/window/syswin.cxx:972
#1  0xefdf1ba1 in framework::LoadEnv::impl_applyPersistentWindowState (
    this=0xef809d94, xWindow=...)
    at /export/home/pl/vcl111/ooo/framework/source/loadenv/loadenv.cxx:1897
#2  0xefdf6d99 in framework::LoadEnv::impl_loadContent (this=0xef809d94)
    at /export/home/pl/vcl111/ooo/framework/source/loadenv/loadenv.cxx:1148
#3  0xefdf8087 in framework::LoadEnv::startLoading (this=0xef809d94)
    at /export/home/pl/vcl111/ooo/framework/source/loadenv/loadenv.cxx:436
#4  0xefdefcd2 in framework::LoadDispatcher::impl_dispatch (this=0xef809d48, 
    rURL=..., lArguments=..., xListener=...)
    at /export/home/pl/vcl111/ooo/framework/source/dispatch/loaddispatcher.cxx:169
#5  0xefdf006f in framework::LoadDispatcher::dispatchWithReturnValue (
    this=0xef809d48, rURL=..., lArguments=...)
    at /export/home/pl/vcl111/ooo/framework/source/dispatch/loaddispatcher.cxx:106
#6  0xf7cb1527 in
comphelper::SynchronousDispatch::dispatch(com::sun::star::uno::Reference<com::sun::star::uno::XInterface>
const&, rtl::OUString const&, rtl::OUString const&, long,
com::sun::star::uno::Sequence<com::sun::star::beans::Prope

-------------------------------------------------

2. Call
-------
#0  SystemWindow::SetWindowState (this=0xef7e572c, rStr=...)
    at /export/home/pl/vcl111/ooo/vcl/source/window/syswin.cxx:972
#1  0xefe4b675 in
framework::PersistentWindowState::implst_setWindowStateOnWindow (xWindow=...,
sWindowState=...)
    at
/export/home/pl/vcl111/ooo/framework/source/helper/persistentwindowstate.cxx:346
#2  0xefe4c162 in framework::PersistentWindowState::frameAction (
    this=0xef10c760, aEvent=...)
    at
/export/home/pl/vcl111/ooo/framework/source/helper/persistentwindowstate.cxx:166
#3  0xefd6d1a0 in framework::Frame::implts_sendFrameActionEvent (
    this=0xf0f06550, aAction=@0xffffb2cc)
    at /export/home/pl/vcl111/ooo/framework/source/services/frame.cxx:2792
#4  0xefd70af7 in framework::Frame::setComponent (this=0xf0f06550, 
    xComponentWindow=..., xController=...)
    at /export/home/pl/vcl111/ooo/framework/source/services/frame.cxx:1473
#5  0xf78b0c89 in ?? ()
   from
/export/home/pl/vcl111/oracle-openoffice-3.2-linux-en-US/oracle_open_office3/program/../basis-link/program/libsfxli.so
#6  0xf78b5a96 in ?? ()
   from
/export/home/pl/vcl111/oracle-openoffice-3.2-linux-en-US/oracle_open_office3/program/../basis-link/program/libsfxli.so
#7  0xefdf7206 in framework::LoadEnv::impl_loadContent (this=0xef809d94)
    at /export/home/pl/vcl111/ooo/framework/source/loadenv/loadenv.cxx:1215
#8  0xefdf8087 in framework::LoadEnv::startLoading (this=0xef809d94)
    at /export/home/pl/vcl111/ooo/framework/source/loadenv/loadenv.cxx:436
#9  0xefdefcd2 in framework::LoadDispatcher::impl_dispatch (this=0xef809d48, 
    rURL=..., lArguments=..., xListener=...)
    at /export/home/pl/vcl111/ooo/framework/source/dispatch/loaddispatcher.cxx:169
#10 0xefdf006f in framework::LoadDispatcher::dispatchWithReturnValue (
    this=0xef809d48, rURL=..., lArguments=...)
    at /export/home/pl/vcl111/ooo/framework/source/dispatch/loaddispatcher.cxx:106
#11 0xf7cb1527 in
comphelper::SynchronousDispatch::dispatch(com::sun::star::uno::Reference<com::sun::star::uno::XInterface>
const&, rtl::OUString const&, rtl::OUString const&, long,
com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) ()
   from
/export/home/pl/vcl111/oracle-openoffice-3.2-linux-en-US/oracle_open_office3/program/../basis-link/program/libcomphelp4gcc3.so
#

cd: Accepted.

cd: I discussed a possible fix with the framework team. We concluded that the
fix has too many regression potential. Therefore I will set this issue to OOo 3.4.

If you believe that this issue should be handled as a showstopper for OOo3.3
please nominate it accordingly in the releases mailing list.

thanks for you investigations, of course I would like to see this issue fixed in
3.3. ;-)

however, IMHO it's far away from a potential showstopper, so I'm fine with
target 3.4

cd: Fixed.

cd: Set pl on CC.

cd->pl: Please review fix. See: http://hg.services.openoffice.org/cws/fwk167/rev/4bec1f6543df

fix reviewed

cd->tm: Please send this issue to the right QA engineer for verification.

Checked and verified in cws fwk167 -> OK !