Apache OpenOffice (AOO) Bugzilla – Issue 111413
[ODFF] implement secant functions
Last modified: 2013-08-07 15:13:10 UTC
ODF 1.2 defines the function SEC, CSC, SECH and CSCH. OOo should implement them. Gnumeric knows this functions already. I have made the necessary changes, but any filters.
Created attachment 69323 [details] set of patches to DEV300m76
Applied with two changes: * In the mean time the help ID system changed from numeric IDs (formerly for interpreter functions in sc/inc/scfuncs.hrc) to string IDs, now in sc/inc/helpids.h * Implementation allowed the functions to have more than one parameter, of which only the last is evaluated. There's a special section in formula/inc/formula/compiler.hrc between SC_OPCODE_START_1_PAR and SC_OPCODE_STOP_1_PAR that lets the compiler check for exactly one parameter being passed for those functions. Moved SC_OPCODE_COSECANT, SC_OPCODE_SECANT, SC_OPCODE_COSECANT_HYP and SC_OPCODE_SECANT_HYP there. Also added RTL_LOGFILE_CONTEXT_AUTHOR to interpreter functions, credit to whom credit is due ;-)
In cws dr78: changeset ff05fcb4fe39 http://hg.services.openoffice.org/cws/dr78/changeset/ff05fcb4fe39 M formula/inc/formula/compiler.hrc M formula/inc/formula/opcode.hxx M formula/source/core/resource/core_resource.src M sc/inc/helpids.h M sc/source/core/inc/interpre.hxx M sc/source/core/tool/interpr1.cxx M sc/source/core/tool/interpr4.cxx M sc/source/ui/src/scfuncs.src M sc/util/hidother.src You can observe the progress and possible integration date of CWS dr78 at http://tools.services.openoffice.org/EIS2/cws.ShowCWS?Path=DEV300%2Fdr78
added support for the new secant functions to the Excel XLS export filter. Every occurance of SEC(x) will be replaced with (1/COS(x)); CSC(x) with (1/SIN(x)); SECH(x) with (1/COSH(x)); CSCH(x) with (1/SINH(x)).
Created attachment 75958 [details] testcase
Reassigning to QA for verification.
Seen ok in cws -> verified
grml.. CWS dr78 didn't make it before translation freeze, string changes would pollute translation data. Removed all translation relevant strings from SEC, CSC, SECH and CSCH. The core feature is still available, documents containing the functions can be loaded and saved, but the UI function names are non-translatable English names and function wizard resource is not available. TODO: undo this change for the next release. In cws dr78: changeset 12adc8781f9c http://hg.services.openoffice.org/cws/dr78/changeset/12adc8781f9c M formula/source/core/resource/core_resource.src M sc/inc/helpids.h M sc/source/ui/src/scfuncs.src M sc/util/hidother.src
(In reply to comment #8) > grml.. CWS dr78 didn't make it before translation freeze, string changes > would pollute translation data. Removed all translation relevant strings > from SEC, CSC, SECH and CSCH. The core feature is still available, documents > containing the functions can be loaded and saved, but the UI function names > are non-translatable English names and function wizard resource is not > available. > > TODO: undo this change for the next release. > > In cws dr78: > > changeset 12adc8781f9c > http://hg.services.openoffice.org/cws/dr78/changeset/12adc8781f9c > M formula/source/core/resource/core_resource.src > M sc/inc/helpids.h > M sc/source/ui/src/scfuncs.src > M sc/util/hidother.src The link is this: http://hg.services.openoffice.org/DEV300/rev/12adc8781f9c We just have to put back the translation strings so our pootle guys do their job. Looks like an easy task for a beginner.
reintegrated the resource strings for localization
"jsc" committed SVN revision 1450153 into trunk: #111413# reintegrate resource strings for translation
reintegrate resource strings, they should be now contained in the next translation cycle