Issue 112596 - [From Symphony]Workbooks(...) does not work well in some cases
Summary: [From Symphony]Workbooks(...) does not work well in some cases
Status: CONFIRMED
Alias: None
Product: App Dev
Classification: Unclassified
Component: vba (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: All All
: P3 Trivial
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-22 10:04 UTC by lihuiibm
Modified: 2017-05-20 11:29 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Test sample for this issue (73.50 KB, text/plain)
2010-06-22 10:10 UTC, lihuiibm 		no flags Details
Patch for this issue (1.55 KB, text/plain)
2010-06-22 10:11 UTC, lihuiibm 		no flags Details
Change the fix according to noel's comments. (1.49 KB, patch)
2010-06-22 11:07 UTC, lihuiibm 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description lihuiibm 2010-06-22 10:04:03 UTC 
Workbooks(...) does not work well in some cases:
If opened spreadsheet files' name has space char, such as "Hello VBA.xls",
Workbooks(""Hello VBA.xls").Name throws a error "...NoSuchElementException...".
Comment 1 lihuiibm 2010-06-22 10:10:06 UTC 
Created attachment 70140 [details]
Test sample for this issue
Comment 2 lihuiibm 2010-06-22 10:11:51 UTC 
Created attachment 70141 [details]
Patch for this issue
Comment 3 noel.power 2010-06-22 10:39:07 UTC 
The patch is a little confusing, the following lines are not used at all

INetURLObject aURL( xModel->getURL() );
rtl::OUString sName = aURL.GetLastName();

constucting an object seems a little wasteful but its better than copying and
pasting ;-) I think if you remove the lines above then its ok to commit and upstrem
Comment 4 lihuiibm 2010-06-22 11:07:27 UTC 
Created attachment 70142 [details]
Change the fix according to noel's comments.
Comment 5 Marcus 2017-05-20 11:29:22 UTC 
Reset assigne to the default "issues@openoffice.apache.org".