Issue 112837 - DEV300_m84: WaE in vbahelper
Summary: DEV300_m84: WaE in vbahelper
Status: ACCEPTED
Alias: None
Product: App Dev
Classification: Unclassified
Component: vba (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: All All
: P3 Trivial
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact: noel.power
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-01 07:01 UTC by pavel
Modified: 2013-02-24 20:56 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description pavel 2010-07-01 07:01:12 UTC
Module vbahelper WaE:

/home/oo/BuildDir/ooo_DEV300_m84_src/vbahelper/source/vbahelper/vbahelper.cxx: In function 
'double ooo::vba::PixelsToPoints(com::sun::star::uno::Reference<com::sun::star::awt::XDevice>&, 
double, sal_Bool)':
/home/oo/BuildDir/ooo_DEV300_m84_src/vbahelper/source/vbahelper/vbahelper.cxx:838: warning: 
passing 'double' for argument 1 to 'double ooo::vba::HmmToPoints(sal_Int32)'
/home/oo/BuildDir/ooo_DEV300_m84_src/vbahelper/source/vbahelper/vbahelper.cxx: In member 
function 'virtual void ooo::vba::UserFormGeometryHelper::setLeft(double)':
/home/oo/BuildDir/ooo_DEV300_m84_src/vbahelper/source/vbahelper/vbahelper.cxx:1071: warning: 
passing 'double' for argument 1 to 'sal_Int32 
ooo::vba::UserFormGeometryHelper::ConvertPixelToLogic(sal_Int32, sal_Bool, sal_Bool,
/home/oo/BuildDir/ooo_DEV300_m84_src/vbahelper/source/vbahelper/vbahelper.cxx: In member 
function 'virtual void ooo::vba::UserFormGeometryHelper::setTop(double)':
/home/oo/BuildDir/ooo_DEV300_m84_src/vbahelper/source/vbahelper/vbahelper.cxx:1123: warning: 
passing 'double' for argument 1 to 'sal_Int32 
ooo::vba::UserFormGeometryHelper::ConvertPixelToLogic(sal_Int32, sal_Bool, sal_Bool,
/home/oo/BuildDir/ooo_DEV300_m84_src/vbahelper/source/vbahelper/vbahelper.cxx: In member 
function 'virtual void ooo::vba::UserFormGeometryHelper::setWidth(double)':
/home/oo/BuildDir/ooo_DEV300_m84_src/vbahelper/source/vbahelper/vbahelper.cxx:1175: warning: 
passing 'double' for argument 1 to 'sal_Int32 
ooo::vba::UserFormGeometryHelper::ConvertPixelToLogic(sal_Int32, sal_Bool, sal_Bool,
/home/oo/BuildDir/ooo_DEV300_m84_src/vbahelper/source/vbahelper/vbahelper.cxx: In member 
function 'virtual void ooo::vba::UserFormGeometryHelper::setHeight(double)':
/home/oo/BuildDir/ooo_DEV300_m84_src/vbahelper/source/vbahelper/vbahelper.cxx:1227: warning: 
passing 'double' for argument 1 to 'sal_Int32 
ooo::vba::UserFormGeometryHelper::ConvertPixelToLogic(sal_Int32, sal_Bool, sal_Bool,
dmake:  Error code 1, while making '../../unxlngx6.pro/slo/vbahelper.obj'

Patch attached.
Comment 1 pavel 2010-07-01 08:24:57 UTC
and in sc:

/home/oo/BuildDir/ooo_DEV300_m84_src/sc/source/ui/vba/vbasheetobjects.cxx: In member function 
'virtual com::sun::star::uno::Any ScVbaGraphicObjectsBase::Add(const com::sun::star::uno::Any&, const 
com::sun::star::uno::Any&, const com::sun::star::uno::Any&, const com::sun::star::uno::Any&)':
/home/oo/BuildDir/ooo_DEV300_m84_src/sc/source/ui/vba/vbasheetobjects.cxx:344: warning: 
passing 'double' for argument 1 to 'com::sun::star::awt::Point::Point(const sal_Int32&, const sal_Int32&)'
/home/oo/BuildDir/ooo_DEV300_m84_src/sc/source/ui/vba/vbasheetobjects.cxx:344: warning: 
passing 'double' for argument 2 to 'com::sun::star::awt::Point::Point(const sal_Int32&, const sal_Int32&)'
/home/oo/BuildDir/ooo_DEV300_m84_src/sc/source/ui/vba/vbasheetobjects.cxx:345: warning: 
passing 'double' for argument 1 to 'com::sun::star::awt::Size::Size(const sal_Int32&, const sal_Int32&)'
/home/oo/BuildDir/ooo_DEV300_m84_src/sc/source/ui/vba/vbasheetobjects.cxx:345: warning: 
passing 'double' for argument 2 to 'com::sun::star::awt::Size::Size(const sal_Int32&, const sal_Int32&)'
dmake:  Error code 1, while making '../../../unxlngx6.pro/slo/vbasheetobjects.obj'
ERROR: error 65280 occurred while making 
/home/oo/BuildDir/ooo_DEV300_m84_src/sc/source/ui/vba
Comment 2 noel.power 2010-07-09 10:19:46 UTC
huh, what changed in m84, I didn't commit any vba api stuff. Ok seems this is
done by upstream

also, the patch is missing, reassign to dr ( probably best to fix that in mib17
I guess )
Comment 3 daniel.rentz 2010-07-09 18:45:12 UTC
@noel I think this is caused by the change in VBA userforms supporting AppFont
units I mentioned in some mail (the solution without oox::GraphicHelper)

I am wondering how this went into master with warnings
Comment 4 daniel.rentz 2010-08-17 09:49:38 UTC
target