Apache OpenOffice (AOO) Bugzilla – Issue 113385
Wrong icons in Writer's Frame and OLE toolbars
Last modified: 2021-06-10 13:44:07 UTC
Insert a frame or an OLE object into a Writer doc. Look at the Frame toolbar or the OLE toolbar. You see three icons that look like "Text left aligned, text centered, text right aligned". Those icons need be replaced in the UI by the correct icons for object alignment, as for example res/commandimagelist/sc_objectalign.png. The Help still shows the correct icons from former UI versions. Open homepage of Writer Help, click in the right page at Toolbars, then click Frame toolbar.
Created attachment 70787 [details] Three wrong icons in Frame toolbar
Reset assigne to the default "issues@openoffice.apache.org".
(In reply to Uwe Fischer from comment #0) > Insert a frame or an OLE object into a Writer doc. > Look at the Frame toolbar or the OLE toolbar. > You see three icons that look like "Text left aligned, text centered, text > right > aligned". > Those icons need be replaced in the UI by the correct icons for object > alignment, as for example res/commandimagelist/sc_objectalign.png. > The Help still shows the correct icons from former UI versions. Open > homepage of > Writer Help, click in the right page at Toolbars, then click Frame toolbar. In fact also the three icons for Top, Center and Bottom are not corresponding to the icons in the help.
Created attachment 86454 [details] Correct icons in Frame toolbar
(In reply to Matthias Seidel from comment #4) > Created attachment 86454 [details] > Correct icons in Frame toolbar I think the help is wrong regarding the icons for horizontal and vertical alignment. For me the usage of the icons shown in the screenshot above is more logical.
"mseidel" committed SVN revision 1835905 into trunk: #i113385#
Fixed in trunk for Galaxy icon set. I will have a look into Industrial and Classic icon set.
"mseidel" committed SVN revision 1835919 into trunk: #i113385#
"mseidel" committed SVN revision 1835956 into trunk: #i113385#
Fixed in trunk for Industrial and Classic icon set.
Setting this issue as fixed. Help will be fixed in separate steps.
Unfortunately my first attempt did interfere with the Calc toolbar. Re-opening this issue.
"mseidel" committed SVN revision 1838679 into trunk: i113385 - Reverted all icon changes
"mseidel" committed SVN revision 1841505 into trunk: i113385 - Use correct UNO commands for object allignment (Frame and OLE toolbar)
"mseidel" committed SVN revision 1841506 into trunk: i113385 - Use correct icons in help
I *think* the icons are OK now, but it would be good if a second person would have a look at it...
When inserting a frame or OLE object and selecting the object (green handles are visible) I can see still the 3 icons for text alignment (attached by Uwe). I don't see the 3 attached by Matthias (tested with AOO 4.1.10 on Win 10).
Hi Marcus, That's why "Last Confirmation in" is set to 4.1.10. ;-) Of course this needs to be tested with trunk or 4.2.0. The commits have not been backported to 4.1.x.
@Matthias: I expect to get a AOO 4.2.0 Dev Build from here, right? https://ci.apache.org/projects/openoffice/install/win41x/
(In reply to Marcus from comment #19) > @Matthias: > I expect to get a AOO 4.2.0 Dev Build from here, right? > https://ci.apache.org/projects/openoffice/install/win41x/ Yes, that is the one from our buildbots. And as always, I have private test builds available here: https://home.apache.org/~mseidel/AOO-builds/AOO-420-Test/Full%20Installation/ However, all this was committed when 4.2.0 was our trunk branch. Trunk then became 4.5.0 and I am not sure if this is ready for a 4.2.0 release.
After installing I've inserted an OLE object and frame I can confirm that the 3 icons changed - from text alignment to object alignment. However, the help shows still the wrong icons (for text alignment).