Issue 113478 - Fixes to Serbian hyphenation patterns for integration in sr dictionary
Summary: Fixes to Serbian hyphenation patterns for integration in sr dictionary
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: spell checking (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: stefan.baltzer
QA Contact: issues@lingucomponent
URL: http://ooo.matf.bg.ac.rs/dict-sr/hyph...
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-27 20:46 UTC by grakic
Modified: 2017-05-20 11:42 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
Hyphenation patterns (18.10 KB, application/x-compressed)
2010-08-18 10:36 UTC, grakic
no flags Details
dictionaries/sr/dictionaries.xcu (2.12 KB, text/plain)
2010-08-18 12:56 UTC, grakic
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description grakic 2010-07-27 20:46:52 UTC
László Németh recently forwarded an email from Martin Srebotnjak to lingu-dev 
list who found that Serbian (and some others) hyphenation patterns were not 
properly converted from TeX patterns.

I made a new release of hyphenation patterns for Serbian Cyrillic and Serbian 
Latin fixing this issue, with files hyph_sr.dic and hyph_sh.dic available in:
http://ooo.matf.bg.ac.rs/dict-sr/hyph_sr-20100727.zip

These should replace previous files in dictionaries/sr source tree.
Comment 1 thomas.lange 2010-07-28 07:28:30 UTC
Setting target to 3.3. 
However I do not plan to do it right away but close to the release, since there
may be further updates and then we would need to do this twice.
Comment 2 thomas.lange 2010-07-28 07:28:56 UTC
.
Comment 3 thomas.lange 2010-07-28 07:32:36 UTC
tl->goranrakic: In the meanwhile (if you are the owner) you may want to upload a
updated version of the Serbian dictionary extension to the repository. That way
users that use this extension will get the fix right away.

If you are updating the extension please add a link to the new one here as well.
(In that case I will later on take ALL the data from the extension and add it to
the source code.)
Comment 4 grakic 2010-07-28 10:09:57 UTC
I am thinking about doing some minor updates to the spellcheck dictionary before 
releasing new extension. Can you give me some estimate on deadline when I should 
have this ready to keep 3.3 as a target?
Comment 5 thomas.lange 2010-07-28 10:21:19 UTC
Release is currently planned for November, thus about early October should be
fine in order for QA to get their work done as well.
Comment 6 thomas.lange 2010-08-18 10:34:02 UTC
tl->goranrakic: The provided link is not working, I always got time-outs. Since
hyphenation dictionaries tend to be small, can you attach it to this issue? Thanks!
Comment 7 grakic 2010-08-18 10:36:13 UTC
Created attachment 71162 [details]
Hyphenation patterns
Comment 8 grakic 2010-08-18 10:39:04 UTC
File attached to this issue.

Yes, there is a hardware error with our server located at the Faculty of 
Mathematics in Belgrade. Network administrator is on holiday and I am not able to 
find anybody else to talk with about this issue. I hope it will be resolved in a 
week or so.
Comment 9 thomas.lange 2010-08-18 11:45:25 UTC
Fixed in CWS sw33bf08.

tl->goranrakic : Please make sure this changes will be included in the next
extension update as well. Thanks!
Comment 10 grakic 2010-08-18 12:21:03 UTC
I just made a new extension release including these fixes.
http://extensions.services.openoffice.org/en/project/dict-sr

It also does include an update to dictionaries.xcu. As suggested in your comment 
on Issue 96422 and as it is already in the integrated file 
dictionaries/sr/dictionaries.xcu, I removed "sr" and "sh" locales to avoid 
duplicate language list entries.

Then I also removed sr-CS and sh-CS from dictionaries.xcu and do not see any 
problems. It looks like both sr-CS and sr-YU are mapped to the same language 
entry ("Serbian Cyrillic (Serbia and Montenegro)"). They do not cause duplicate 
entries like "sr" does, it is like they overwrite each other. I do not know 
which one will be more correct to keep "sr_CS" or "sr_YU"?
Comment 11 thomas.lange 2010-08-18 12:52:39 UTC
For cyrillic Serbian there are four possible choices
  - "sr-RS"  SERBIAN_CYRILLIC_SERBIA
  - "sr-CS"  SERBIAN_CYRILLIC
  - "sr-ME"  SERBIAN_CYRILLIC_MONTENEGRO
  - "sr-BA"  SERBIAN_CYRILLIC_BOSNIA_HERZEGOVINA
("sr-YU" is outdated and should not be used)
I was already in the process of building the CWS thus please make a quick choice
which of the above 4 should be used (and for which dictionary )and I will update
the extension once more.
Comment 12 grakic 2010-08-18 12:55:53 UTC
sr-RS and sr-CS, then also sh-RS and sh-CS

I will upload suggested dictionaries.xcu now
Comment 13 grakic 2010-08-18 12:56:24 UTC
Created attachment 71166 [details]
dictionaries/sr/dictionaries.xcu
Comment 14 thomas.lange 2010-08-18 12:59:11 UTC
Thanks!
Comment 15 thomas.lange 2010-08-19 09:45:23 UTC
.
Comment 16 stefan.baltzer 2010-08-23 13:04:07 UTC
Serbian dictionary now is from 2010-08-18. No examples for changes were given,
but hyphenation still works (Latin+Cyrillic).
Verified in CWS sw33bf08.