Issue 116001 - TextFitToSize item can be optimized
Summary: TextFitToSize item can be optimized
Alias: None
Product: Impress
Classification: Application
Component: code (show other issues)
Version: DEV300m93
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact: issues@graphics
Depends on:
Reported: 2010-12-08 17:00 UTC by sven.jacobi
Modified: 2017-05-20 10:44 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Document with stretch WordArt and with justify WordArt (28.50 KB, application/msword)
2010-12-08 17:53 UTC, Regina Henschel
no flags Details
Missing adaptions in binfilter (9.58 KB, patch)
2012-07-30 14:29 UTC, Armin Le Grand
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description sven.jacobi 2010-12-08 17:00:13 UTC
When saving the SdrTextFitToSizeTypeItem to XML the enum values PROPORTIONAL,
ALLLINES and RESIZEATTR are stored as draw:fit-to-size = TRUE. When Reloading
such document, only the enum values NONE and PROPORTIONAL are used and set.

So it is obvious that this item can and should be optimized:
- TextFitToSize at the api should be changed to type bool
- The SdrTextFitToSizeTypeItem itsef at the core should be changed to type bool
- Each code which takes care of ALLLINES and RESIZEATTR can be removed
Comment 1 Regina Henschel 2010-12-08 17:52:27 UTC
Deleting this alignments would make it impossible to import Microsoft Word
documents like the attached one.
Comment 2 Regina Henschel 2010-12-08 17:53:59 UTC
Created attachment 75286 [details]
Document with stretch WordArt and with justify WordArt
Comment 3 Armin Le Grand 2010-12-08 18:02:29 UTC
AW->SJ: Please evaluate if this is true. If Yes, it needs to be solved by
Comment 4 sven.jacobi 2010-12-13 10:45:57 UTC
We will have no problems. The TextFitToSizeTypeItem can be optimized as I said.

The indicated problems from Regina have to be solved otherwise.
TextFitToSizeTypeItem != NONE has to display the WordArt stretched -> So it
doesn't matter if TextFitToSizeType is an enum or bool.

Justified WordArt is an unimplemented feature, this has to be fixed in
svx/source/customshapes/enhancedcustomshapefontwork.cxx in GetFontWorkOutline,
there SDRTEXTHORZADJUST_BLOCK needs to be supported. At the moment BLOCK is 
left aligned, which is a bug.
Comment 5 Armin Le Grand 2012-07-26 11:24:19 UTC
ALG: Checked some aspects; Indeed the property is already a bool in ODF, so no problems there: Also checked all usages, these are indeed all 'booleanized'. Api usage is an enum now, but should be changed to bool, too. Checking some more aspects...
Comment 6 Armin Le Grand 2012-07-26 16:01:08 UTC
ALG: Adapted all usages to bool, removed unused types, complete build and install, checked load/save of samples using FitToSize, works well. Trying to find more unused parts...
Comment 7 Armin Le Grand 2012-07-26 16:57:15 UTC
ALG: Found and removed some unused strings, corrected one more place to boolean. Rebuild, works well. Checkin of changes.
Comment 8 SVN Robot 2012-07-26 17:03:22 UTC
"alg" committed SVN revision 1366087 into trunk:
#116001# TextToFitSize item/property optimized to boolean
Comment 9 Armin Le Grand 2012-07-26 17:03:44 UTC
ALG: Done.
Comment 10 Regina Henschel 2012-07-28 13:07:52 UTC
The enum TextFitToSizeType belongs to a published API and is not yet marked as [DEPRECATED]. Wouldn't it be the correct way to first mark it as [DEPRECATED] with a comment what is to be used instead?
Comment 11 Armin Le Grand 2012-07-30 11:50:12 UTC
ALG: Reopening, missing adaptions in binfilter and qadevOOo.
Comment 12 Armin Le Grand 2012-07-30 14:29:34 UTC
Created attachment 78784 [details]
Missing adaptions in binfilter

ALG: Added missing adaptions in binfilter for reference
Comment 13 SVN Robot 2012-07-30 17:37:21 UTC
"alg" committed SVN revision 1367187 into trunk:
#116001# Reverted revision 1366087
Comment 14 Armin Le Grand 2012-07-30 17:38:45 UTC
ALG: Reverted 1366087, complete test build. Comitted as revision 1367187. Sorry again for the inconveniecnes.
This task may be reactivated for a major release (if wanted at all), all needed changes would be here.
Comment 15 2013-07-11 12:59:47 UTC
Adjusted issue status to the fact that the commit has been reverted.
Comment 16 Marcus 2017-05-20 10:44:12 UTC
Reset the assignee to the default "".