Issue 116631 - crash when undo in Comment when text is removed with undo
Summary: crash when undo in Comment when text is removed with undo
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: code (show other issues)
Version: OOo 3.3 RC10
Hardware: All All
: P3 Trivial (vote)
Target Milestone: 3.4.0
Assignee: stefan.baltzer
QA Contact: issues@sw
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2011-01-26 11:27 UTC by cno
Modified: 2017-05-20 10:30 UTC (History)
5 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description cno 2011-01-26 11:27:21 UTC 
- start new document
- type some words
- Insert > Comment
- type a word
- Ctrl-Z untill text is gone
- Ctrl-Z once more
  > crash

is present in 330m20 and 300m97
Comment 1 cno 2011-01-26 11:32:50 UTC 
crash report sent to Hamburg, will post ID here of course ;-)
Comment 2 cno 2011-01-26 11:39:17 UTC 
Sorry, I found the crash when just doing some work with m97. 
Just checked that it is not present in 321.
Comment 3 cno 2011-01-26 11:44:09 UTC 
crash rprt ID r8ywpcn
Comment 4 michael.ruess 2011-01-26 13:01:12 UTC 
Curious... this has been fixed for OOo 3.2 (see issue 108813), but now re-occurs...
To reproduce, just insert comment and a word into it, two times undo -> crash.
Comment 5 cno 2011-01-26 13:45:41 UTC 
@mru: maybe branches ;-)

target 3.3.1 & 3.4.0 ?
Comment 6 Oliver Brinzing 2011-01-26 17:35:45 UTC 
,
Comment 7 Oliver-Rainer Wittmann 2011-02-18 09:57:51 UTC 
fix of issue 108813 could lost by the refactorings done with issue 88070 in cws
sw33a11y01
Comment 8 mst.ooo 2011-03-01 13:14:04 UTC 
mine
Comment 9 mst.ooo 2011-03-01 15:54:24 UTC 
apparently the fix from the other issue got lost,
or was never integrated on DEV300.

fixed in CWS sw34bf04
http://hg.services.openoffice.org/hg/cws/sw34bf04/rev/08037de1f387
Comment 10 michael.ruess 2011-03-16 15:00:22 UTC 
Verified in CWS sw34bf04.
Comment 11 stefan.baltzer 2011-03-16 15:49:56 UTC 
I could reproduce this in DEV300_m98, but not in m99 or younger. OD helped me to solve this riddle as defects tend NOT to fix themselves :-)

Conclusion: This one was fixed "along the way" in DEV300_m99 via undo code refactoring in CWS undoapi. Thus it can not be reproduced in m99 already. 
ODs "old fix" was applied "anyway" in CWS sw34bf04. So this can be regarded as "fixed twice" :-)

Verified in CWS sw34bf04.