Issue 116738 - installation set contains broken python test files
Summary: installation set contains broken python test files
Status: CLOSED FIXED
Alias: None
Product: Installation
Classification: Application
Component: code (show other issues)
Version: OOo 3.2.1
Hardware: All Windows XP
: P3 Trivial (vote)
Target Milestone: 3.4.1
Assignee: b.osi.ooo
QA Contact: issues@installation
URL:
Keywords:
: 116938 117027 (view as issue list)
Depends on:
Blocks:
 
Reported: 2011-01-31 22:39 UTC by frankmundtotde
Modified: 2011-03-31 12:12 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
avira avscan (13.70 KB, text/plain)
2011-01-31 22:42 UTC, frankmundtotde
no flags Details
check changes to installation sets (329.81 KB, text/plain)
2011-03-07 08:24 UTC, Stephan Bergmann
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description frankmundtotde 2011-01-31 22:39:33 UTC
Start of the scan: 31 January 2011  20:51

Starting the file scan:

Begin scan in 'E:\Downloads\OOo_3.2.1_Win_x86_install-wJRE_en-GB.exe'
E:\Downloads\OOo_3.2.1_Win_x86_install-wJRE_en-GB.exe
[0] Archive type: NSIS
  --> l
    [1] Archive type: CAB (Microsoft)
    --> testtar.tar
      [2] Archive type: TAR (tape archiver)
--> 
gnu/123/123/123/123/123/123/123/123/123/123/123/123/123/123/123/123/123/123/123/
123/123/123/123/123/123/123/123/123/123/123/123/123/123/123/123/123/123/123/123/
123/123/123/123/123/123/123/123/123/123/123/123/123/123/123/123/123/123/123/123/
123/123/123/123/123/123/123/123/123/123/123/123/123/123/123/123/123/123/123/123/
123/123/123/123/123/123/123/123/123/123/123/123/123/123/123/123/123/123/123/123/
123/123/123/123/123/123/123/123/123/123/123/123/123/123/123/123/123/123/123/123/
123/123/123/123/123/123/longname
  [WARNING]   Internal error!
Comment 1 frankmundtotde 2011-01-31 22:42:33 UTC
Created attachment 75735 [details]
avira avscan
Comment 2 Marcus 2011-02-01 10:10:18 UTC
maybe the download is broken or somehow invalid, please download again
Comment 3 Marcus 2011-02-01 10:10:42 UTC
closed
Comment 4 frankmundtotde 2011-02-02 08:53:56 UTC
have downloaded ok three times.  internal error still remains as reported by 
avscan.
Comment 5 Olaf Felka 2011-02-02 09:51:46 UTC
I think that this is a problem in avscan.
Comment 6 Olaf Felka 2011-02-13 08:53:22 UTC
*** Issue 116938 has been marked as a duplicate of this issue. ***
Comment 7 frankmundtotde 2011-02-13 09:26:55 UTC
so there is no problem with the avira report.   the download has an internal 
error which does not affect functionality, but needs to be cleaned up to avoid 
the impression of careless untidy programming.
Comment 8 Olaf Felka 2011-02-13 09:52:33 UTC
*** Issue 116938 has been marked as a duplicate of this issue. ***
Comment 9 Olaf Felka 2011-02-14 10:49:02 UTC
@ mt and jbu: How to proceed with this issue? Can we get rid of the "C:\Program
Files\OpenOffice.org 3\Basis\program\python-core-2.6.1\lib\test\testtar.tar"?
Can we ignore the error of the Avira tool? Should the Avira people fix their stuff?
Comment 10 malte_timmermann 2011-02-14 12:19:05 UTC
The testtar.tar is broken, and actually we shouldn't ship the test folder at all.

Or do we need to keep the test folder because of license/redistribution rules?

Joerg - as you brought python into the OOo installation set, would you like to
cleanup?

Confirmed issue, change title accordingly.
Comment 11 Rainer Bielefeld 2011-02-20 07:28:28 UTC
*** Issue 117027 has been marked as a duplicate of this issue. ***
Comment 12 Olaf Felka 2011-02-25 11:05:08 UTC
@ mt: would you like to remove this tar file?
Comment 13 malte_timmermann 2011-03-03 11:14:55 UTC
mt->sb: As jbu didn't answer, you volunteered to take over :)
Comment 14 Stephan Bergmann 2011-03-04 13:34:40 UTC
fixed as <http://hg.services.openoffice.org/cws/sb142/rev/ba5cb7326fb6> (Python-2.6.1/Lib/test/README indicates that those files are only for testing purposes, anyway)
Comment 15 Stephan Bergmann 2011-03-07 08:24:34 UTC
Created attachment 76036 [details]
check changes to installation sets

Little script (against Hamburg environment) to verify that the fix for this bug removed exactly the unwanted test directory, on all platforms (and at least for the archive installation sets).  The observed variation in python-core-2.6.1/lib/lib-dynload/ and share/prereg/bundled/registry/com.sun.star.comp.deployment.configuration.PackageRegistryBackend/ is a normal build artifact.
Comment 16 Stephan Bergmann 2011-03-07 08:26:10 UTC
@tbo: please verify
Comment 17 b.osi.ooo 2011-03-14 09:47:00 UTC
verified on linux in CWS sb142 - no more a test directory available.