Issue 116922 - to-be-m100: mixed mode mktemp template may not be generated
Summary: to-be-m100: mixed mode mktemp template may not be generated
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: GNU make (show other issues)
Version: current
Hardware: PC Windows, all
: P3 Normal (vote)
Target Milestone: 3.4.1
Assignee: hjs
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-24 14:31 UTC by hans_werner67
Modified: 2017-05-20 10:31 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Patch for windows.mk and winmingw.mk (977 bytes, text/plain)
2011-02-13 01:43 UTC, tono 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description tono 2011-02-11 10:28:01 UTC 
The following line is introduced in solenv/gbuild/platform/windows.mk with cws
gnumake3.

gb_MKTEMP := mktemp --tmpdir=$(gb_TMPDIR) -t gbuild.XXXXXX

However, when -t is specified, cygwin mktemp uses environment variable TMPDIR,
if set, even though --tmpdir= is specified in the command line.

I think -t should be removed here. Without -t, --tmpdir= works even if
environment variable TMPDIR is set.

And the last but not the least point to be payed attention is that the
modification for generating mixed mode template should be applied to winmingw.mk
as well.
Comment 1 tono 2011-02-13 01:43:09 UTC 
Created attachment 75825 [details]
Patch for windows.mk and winmingw.mk
Comment 2 hjs 2011-03-04 09:31:20 UTC 
fixed on cws gnumakefixes
Comment 3 mst.ooo 2011-03-07 11:41:20 UTC 
looks good to me
Comment 4 Oliver-Rainer Wittmann 2012-06-13 12:22:12 UTC 
getting rid of value "enhancement" for field "severity".
For enhancement the field "issue type" shall be used.