Issue 117133 - New shape fill color not written in all xml formats
Summary: New shape fill color not written in all xml formats
Alias: None
Product: Draw
Classification: Application
Component: save-export (show other issues)
Version: version58
Hardware: PC Windows NT
: P3 Normal (vote)
Target Milestone: 3.4.1
Assignee: wolframgarten
QA Contact: issues@graphics
Keywords: regression
Depends on:
Reported: 2011-02-28 16:34 UTC by clippka
Modified: 2013-01-23 08:21 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Note You need to log in before you can comment on or make changes to this issue.
Description clippka 2011-02-28 16:34:12 UTC
The new fill color for shapes (Blue 9) is not exported in the document pool in sc and sw. This causes old files to be read with also blue 9 as fill color even so it should be blue 8.

cl->cl: use SetPoolDefaultItem
Comment 1 clippka 2011-03-10 13:22:03 UTC
fixed in cws impress210

Calc already had a method to add drawing layer defaults with 

void ScDocument::SetDrawDefaults()
void ScDocument::UpdateDrawDefaults()

SetDrawDefaults is called from ScDocShell::InitNew which is only
called when a new document is created, not when a document is loaded.
SetDrawDefaults will set bSetDrawDefaults to true and call UpdateDrawDefaults.
If the drawing layer model for calc is not yet created, UpdateDrawDefaults will be called upon init of drawing layer model later. Will only put new defaults in item pool if bSetDrawDefaults is true.

Added the same handling to writer

+ SwDoc::SetDrawDefaults()
+ SwDoc::UpdateDrawDefaults()

and SetDrawDefaults is called from SwDocShell::InitNew.

Both UpdateDrawDefaults will call new method

+ void SdrModel::SetDrawingLayerPoolDefaults()

which actually puts the new defaults in the item pool.

In sd, DrawDocShell::InitNew directly calls SdrModel::SetDrawingLayerPoolDefaults().
Comment 2 clippka 2011-03-29 11:49:32 UTC
verified in cws, back to qa

how to test:

create documents in writer, calc, impress, draw with at least one shape with default formating in this cws and in an older version which didn't had blue 9 as the default color. Documents should load in same version and older version with the color they had during save.
Comment 3 wolframgarten 2011-03-31 12:39:01 UTC
Verified in CWS.
Comment 4 Oliver-Rainer Wittmann 2012-06-13 12:23:50 UTC
getting rid of value "enhancement" for field "severity".
For enhancement the field "issue type" shall be used.
Comment 5 2013-01-23 08:21:00 UTC
Closing resolved issue.