Issue 117863 - hidden section: crash + hidden only partly works
Summary: hidden section: crash + hidden only partly works
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: formatting (show other issues)
Version: 3.4.0 Beta (OOo)
Hardware: PC All
: P2 Normal (vote)
Target Milestone: 3.4.0
Assignee: Mathias_Bauer
QA Contact: issues@sw
URL:
Keywords: crash, regression
Depends on:
Blocks:
 
Reported: 2011-04-15 08:48 UTC by Oliver Brinzing
Modified: 2012-06-18 07:03 UTC (History)
7 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
test_hidden_sections (8.10 KB, application/vnd.oasis.opendocument.text)
2011-04-15 08:48 UTC, Oliver Brinzing 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Oliver Brinzing 2011-04-15 08:48:29 UTC 
Created attachment 76387 [details]
test_hidden_sections

steps to reproduce:

- open attached writer document
- F5 (Navigator) -> Sections
- Hide Section "Bereich1.1" (Edit -> Hide)
- "Bereich1.1" is still visible
- save and reload document
- "Bereich1.1" is hidden now

in oo 3.2/3.3 the section will hide immediatelly after hiding ...
-> regression
Comment 1 eric.savary 2011-04-15 09:13:04 UTC 
@OD: this is worst than described...

1) Hiding a simple - not embedded section like in the sample document - section will hide the section boundaries but not its content (text). Saving, reloading and un-hiding the section will display the text 2 times.

2) Showing the Options dialog (i.e. to change the background) of an hidden section will crash.

Both are regressions compared to 3.3. Assuming those problems have the same root cause.
Comment 2 eberlein 2011-04-15 09:18:48 UTC 
.
Comment 3 Oliver-Rainer Wittmann 2011-04-15 09:24:31 UTC 
confirmed and accepted.
start working on this issue
Comment 4 Oliver-Rainer Wittmann 2011-04-15 12:26:00 UTC 
*** Issue 117831 has been marked as a duplicate of this issue. ***
Comment 5 Oliver-Rainer Wittmann 2011-04-15 13:15:30 UTC 
fixed in cws sw34bf06
- correction of hidden section feature:
/sw/inc/section.hxx,
/sw/source/core/layout/sectfrm.cxx,
/sw/source/core/docnode/section.cxx,
/sw/source/core/docnode/ndsect.cxx,
change set http://hg.services.openoffice.org/cws/sw34bf06/rev/d2030e65b6b9
- fix for the crash using the option dialog of hidden sections
/sw/source/core/frmedt/feshview,cxx,
change set http://hg.services.openoffice.org/cws/sw34bf06/rev/ec59153c0f36

od->mba: please review the fix.
Comment 6 Mathias_Bauer 2011-04-15 15:24:56 UTC 
both patches are fine.
Comment 7 Oliver-Rainer Wittmann 2012-06-13 12:23:01 UTC 
getting rid of value "enhancement" for field "severity".
For enhancement the field "issue type" shall be used.
Comment 8 binguo 2012-06-18 07:03:02 UTC 
Verified it on Aoo_Trunk_20120616.1800.1350879 and it does not reproduce, the section will hide immediatelly after hiding in step 3, so close it as fixed.