Issue 119327 - Cannot select presentation display with multiple displays
Summary: Cannot select presentation display with multiple displays
Status: CLOSED FIXED
Alias: None
Product: Impress
Classification: Application
Component: code (show other issues)
Version: 3.4.0
Hardware: PC Linux, all
: P3 Normal (vote)
Target Milestone: 3.4.1
Assignee: Andre
QA Contact:
URL:
Keywords: regression
: 119293 (view as issue list)
Depends on:
Blocks:
 
Reported: 2012-05-10 23:52 UTC by Ariel Constenla-Haile
Modified: 2017-05-20 10:32 UTC (History)
6 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---
jsc: 3.4.1_release_blocker+


Attachments
Multiple displays settings in Fedora 16 with KDE (111.28 KB, image/png)
2012-05-10 23:53 UTC, Ariel Constenla-Haile
no flags Details
"Multiple displays" settings available on OOo 3.3.0 (64.71 KB, image/png)
2012-05-10 23:55 UTC, Ariel Constenla-Haile
no flags Details
OOo 3.3.0: slide show running on secondary display (195.53 KB, image/png)
2012-05-10 23:56 UTC, Ariel Constenla-Haile
no flags Details
AOO 3.4: slide show running (562.43 KB, image/png)
2012-05-11 00:49 UTC, Ariel Constenla-Haile
no flags Details
Add USE_XINARAMA flag to other xinerama flags. (690 bytes, text/plain)
2012-05-16 13:36 UTC, Andre
no flags Details
A better prepared patch. (552 bytes, patch)
2012-05-16 13:59 UTC, Andre
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description Ariel Constenla-Haile 2012-05-10 23:52:20 UTC
On Linux, with a multiple displays set up, the multiple displays are not recognized and the presentation display cannot be set.

To reproduce:

* connect a monitor to the laptop, set the laptop display as the primary display

* open Apache OpenOffice: while OOo 3.3.0 opens on the primary display, AOO opens on the secondary display

* create a presentation

* go to the Menu "Slide Show" -> "Slide Show Settings..." -> "Slide Show" dialog
Under "Multiple displays", "Presentation display" is grayed out, the listbox is disabled.

On OOo 3.3.0 you can choose the presentation display:

- Display 1 (Primary)
- Display 2
- All displays

Note: bug on OOo 3.3.0, selecting "All displays" does not show the presentation on all displays, only the primary.
Comment 1 Ariel Constenla-Haile 2012-05-10 23:53:34 UTC
Created attachment 77524 [details]
Multiple displays settings in Fedora 16 with KDE

The current setting where the bug could be reproduced
Comment 2 Ariel Constenla-Haile 2012-05-10 23:55:13 UTC
Created attachment 77525 [details]
"Multiple displays" settings available on OOo 3.3.0

On OOo 3.3.0 you can select a "Presentation display" (though "All displays" does not work):
Comment 3 Ariel Constenla-Haile 2012-05-10 23:56:28 UTC
Created attachment 77526 [details]
OOo 3.3.0: slide show running on secondary display
Comment 4 Ariel Constenla-Haile 2012-05-10 23:57:14 UTC
Regression from OpenOffice.org 3.3.0
Comment 5 Ariel Constenla-Haile 2012-05-11 00:49:07 UTC
Created attachment 77527 [details]
AOO 3.4: slide show running

The slide show isn't displayed on the secondary display (top of the picture). It seems to be running on the primary display but taking the width of the secondary display. The slide show content is displayed with a vertical and horizontal offset.
Comment 6 Ariel Constenla-Haile 2012-05-11 01:10:29 UTC
*** Issue 119293 has been marked as a duplicate of this issue. ***
Comment 7 Andre 2012-05-11 07:11:52 UTC
I am currently setting up a machine on which I can reproduce this.  Once this is done, I hope that I can fix this without the help of the old VCL team.
Comment 8 Andre 2012-05-15 10:04:23 UTC
I can repdroduce this now (Ubuntu 12.04, 64Bit), although in a slightly different flavor: both monitors are apparently handled as one display, splash screen is displayed in the center and therefore being half on one and half on the other monitor.  The slide show is displayed similar, centered on both monitors with wide black frames on its left and right side.

I hope that it is even possible to get information about the underlying monitor geometries and that not only the virtual display is reported to VCL.
Comment 9 Andre 2012-05-15 15:42:31 UTC
After playing arround with the multi-screen system settings for my ATI card I found out that:

- when xinerama is activated then VCL does not/can not detect that the virtual display really is two displays.  The result is as described in my lst comment.  Strangely enough, in X11SalFrame::ShowFullScreen (in main/vcl/generic/window/salframe.cxx:2195) the test for detecting xinerama fails.

- when xinerama is deactivated then the presentation can be run on either screen.  The presenter screen is displayed on the other, respectively.  All as expected.  Only the "All displays" option is missing (but anyway, I can not drag any window onto the second screen; probably an error in the system configuration)


@Arial, all: Can you tell me about your graphics system configuration (xinerama, randr, graphics card type, etc)?
Comment 10 Andre 2012-05-16 12:54:35 UTC
I have found out what has changed.  The Xinerama initialization in vcl/unx/generic/app/saldisp.cxx is not executed properly because the Xinerama environment variables are not set up anymore.  The reason for that is the transition from dmake to gbuild.  The code for setting up the variables was in the makefile.mk besides saldisp.cxx.  The makefile is gone and so is this code.
Comment 11 Andre 2012-05-16 13:36:25 UTC
Created attachment 77554 [details]
Add USE_XINARAMA flag to other xinerama flags.

Some of the old logic was transferred, but not all.  Re-added the USE_XINERAMA flag that guards most of the xinerama related code in saldisp.cxx.
Comment 12 Andre 2012-05-16 13:37:09 UTC
Taking ownership.
Comment 13 Andre 2012-05-16 13:58:26 UTC
Fixed in revision 1339170.
Comment 14 Andre 2012-05-16 13:59:12 UTC
Created attachment 77555 [details]
A better prepared patch.
Comment 15 Ariel Constenla-Haile 2012-05-16 20:44:22 UTC
(In reply to comment #14)
> Created attachment 77555 [details]
> A better prepared patch.

The patch works:

* go to the Menu "Slide Show" -> "Slide Show Settings..." -> "Slide Show" dialog
Under "Multiple displays", "Presentation display", the listbox is enabled.

* the Presenter Console extension works now
Comment 16 jsc 2012-05-31 14:46:49 UTC
set release blocker flag for 3.4.1
Comment 17 Oliver-Rainer Wittmann 2012-06-06 11:08:40 UTC
merged fix from trunk into branch AOO34, revision 1346824
Comment 18 Li Feng Wang 2012-07-17 10:41:41 UTC
1)Presentation display listbox is enabled.
- Display 1 (Primary)
- Display 2
- All displays

2)After enable xinerama, Slides show can show on all displays.
(make primary and secondary display as one)

Verify pass on Ubuntu with AOO341 branch r1359641.