Issue 119476 - [From Symphony]]Words display incorrectly if the linespacing is set into little than font size in .doc file
Summary: [From Symphony]]Words display incorrectly if the linespacing is set into litt...
Status: CONFIRMED
Alias: None
Product: Writer
Classification: Application
Component: formatting (show other issues)
Version: 3.4.0
Hardware: PC All
: P3 Normal (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-29 03:09 UTC by louqle
Modified: 2012-06-20 12:47 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
sample file (45.00 KB, application/msword)
2012-05-29 03:09 UTC, louqle 		no flags Details
snapshot (62.15 KB, image/png)
2012-05-29 03:10 UTC, louqle 		no flags Details
patch for i119476 (1.37 KB, patch)
2012-06-20 08:35 UTC, zjchen 		orw: review-
Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description louqle 2012-05-29 03:09:37 UTC 
Created attachment 77666 [details]
sample file

build: Aoo 3.4

the sample file cannot display correct in Aoo 3.4
Comment 1 louqle 2012-05-29 03:10:08 UTC 
Created attachment 77667 [details]
snapshot
Comment 2 zjchen 2012-06-19 01:27:41 UTC 
Seems that the paragraph line spacing feature difference cause text display incorrectly. If I manually adjust the line spacing to a larger value. The text will not be clipped.
Comment 3 zjchen 2012-06-20 08:03:21 UTC 
I have found the problem is that there is different text clipped mechanism between AOO & MS Word. In MS Word, if the line spacing add paragraph before spacing is enough to display text, it does not clipped text in paragraph. While in AOO, it just consider the line spacing as the condition to determine whether clipped the text in paragraph.

see the method <SwTxtFormatter::CalcRealHeight(..)> in main\sw\source\core\text\itrform2.cxx Line 1756 for more detail.
Comment 4 zjchen 2012-06-20 08:35:15 UTC 
Created attachment 78402 [details]
patch for i119476

adjust paragraph line spacing and above paragraph spacing steps:
1.select text
2.choose format->Paragraph
3.choose Indent&spacing tab
4.modify spacing (above and below) and line spacing
Comment 5 Oliver-Rainer Wittmann 2012-06-20 11:04:05 UTC 
I have reviewed the patch and checked it.

It works fine, but I think we need some further improvements:
(1) To determine, if more space is available for the first text line, only looking at the attribute is not enough. I will have a deeper look for an improved solution.
(2) There are some painting errors when deleting or inserting characters. These needs to be resolved from my point of view.
Comment 6 Oliver-Rainer Wittmann 2012-06-20 12:47:59 UTC 
Comment on attachment 78402 [details]
patch for i119476

just trying to use Bugzilla workflow:
marking review request with "-" according to the result of my review - see comment 5
(1) improvement regarding space calculation needed from my point of view
(2) correction of paint error needed from my point of view

I will take care of (1)