Apache OpenOffice (AOO) Bugzilla – Issue 120143
[From Symphony]the text in textbox display paritially when opening .ppt file
Last modified: 2017-05-20 10:32:11 UTC
Created attachment 78542 [details] capture.png Build: AOO3.4 rev 1327774 Description: 1. open the sample file in AOO and MS 2. go to slide 3 ,compare the text in textbox between in AOO and MS Defect: the text in textbox display paritially the detail infomation please refer the capture.png
the bug reproduce in AOO version 1351960
Created attachment 78568 [details] sample file
Created attachment 78569 [details] screenshot about details in AOO and MS
I'm checking this defect
root cause: the attr of bullet size imported wrong.
solution: in line 5119-5125 at file "\main\filter\source\msfilter\svdfppt.cxx", if ( nMask & 0x0040 ) // buSize { rIn >> aSet.mpArry[ PPT_ParaAttr_BulletHeight ]; if ( ! ( ( nMask & ( 1 << PPT_ParaAttr_BuHardHeight ) ) && ( nBulFlg && ( 1 << PPT_ParaAttr_BuHardHeight ) ) ) ) aSet.mnAttrSet ^= 0x40; } PPT_ParaAttr_BulletHeight =3 the seventh of aSet.mnAttrSet use to indicate weather bullet has size. the fourth of nMask used to indicate bulletHasSize (1 bit): A bit that specifies whether the bulletFlags field of the TextPFException structure that contains this PFMasks exists and whether bulletFlags.fBulletHasSize is valid. the fourth of nBulFla used to indicate fBulletHasSize (1 bit): A bit that specifies whether the bullet has a size. the logic included if block: only and only if both the fourth of nMask and the fourth of nBulFla is 1, aSet.mnAttrSet is true, otherwise should be set to false. in sample file, the fourth of nBulFla is 0,and the fourth of nMask is 1, in this situation,the seventh of aSet.mnAttrSet should be set false, however the logic ( nBulFlg && ( 1 << PPT_ParaAttr_BuHardHeight ) ) is true, attr have not been set to false, next read bullet size is invalid,so error occur. the right logic should be ( nBulFlg & ( 1 << PPT_ParaAttr_BuHardHeight ) ), check weather the fourth of nBulFlg is 1.
Created attachment 78579 [details] patch for ppt import bullet size error
A great find, thank you very much! Applied as revision 1357304.
Verified on Windows7-64bit &Ubuntu10.04 &Mac10.7 &Redhat &Ubuntu-64bit with AOO trunk r1374181 ,Pass