Issue 120870 - Cube shape geometry is not defined optimally
Summary: Cube shape geometry is not defined optimally
Status: CLOSED NOT_AN_OOO_ISSUE
Alias: None
Product: Impress
Classification: Application
Component: open-import (show other issues)
Version: 4.0.0-dev
Hardware: All All
: P3 Normal (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-10 07:26 UTC by Jianyuan Li
Modified: 2012-09-12 06:03 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Enhancement points (29.41 KB, application/vnd.oasis.opendocument.text)
2012-09-10 07:26 UTC, Jianyuan Li 		no flags Details
Patch for this issue (2.59 KB, patch)
2012-09-10 07:27 UTC, Jianyuan Li 		lijianyuan1983: review?
Details | Diff
UT file for this issue (59.50 KB, application/vnd.ms-powerpoint)
2012-09-10 07:31 UTC, Jianyuan Li 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Jianyuan Li 2012-09-10 07:26:09 UTC 
Created attachment 79376 [details]
Enhancement points

Cube shape geometry is not defined optimally. See more details in my attachment "enh.odt".
Comment 1 Jianyuan Li 2012-09-10 07:27:39 UTC 
Created attachment 79377 [details]
Patch for this issue
Comment 2 Jianyuan Li 2012-09-10 07:31:55 UTC 
Created attachment 79378 [details]
UT file for this issue
Comment 3 Jianyuan Li 2012-09-10 07:34:59 UTC 
Confirm this defect
Comment 4 Regina Henschel 2012-09-10 11:28:31 UTC 
Can you please add a Draw document containing the new shape?

Did you test filling the shape with a hatch filling?

Did you test filling with a linear gradient? The three parts should have own fillings.

Did you test breaking the shape into polygons?

I think, that using own paths for the right and upper parts should not be changed.
Comment 5 Jianyuan Li 2012-09-10 12:01:28 UTC 
@Regina:
A very good catch. Thanks.
For this shape, gradient and hatch does not work as before with my patch. The three are individually for those properties currently.
Comment 6 Jianyuan Li 2012-09-10 12:04:37 UTC 
@Regina:
I think you can invalidate this bug.
Comment 7 Regina Henschel 2012-09-10 16:33:03 UTC 
Totally different way is needed.
Comment 8 Armin Le Grand 2012-09-12 06:03:29 UTC 
ALG: I would not change the shape for 'saving' to paint four lines. Too much trouble involved with filling (imagine we add a 'break' command later, or conversion to 3D). It would be different if at least filled areas would largely ovrlap, but this is not the case. I suggest to take no action at all, I see no defect.