Issue 122738 - Table toolbar not refreshing with applied background
Summary: Table toolbar not refreshing with applied background
Status: CLOSED FIXED
Alias: None
Product: Impress
Classification: Application
Component: formatting (show other issues)
Version: 3.4.0
Hardware: All All
: P3 Normal (vote)
Target Milestone: 4.1.0
Assignee: Armin Le Grand
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-13 20:13 UTC by Edwin Sharp
Modified: 2017-05-20 10:35 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Edwin Sharp 2013-07-13 20:13:04 UTC 
Test Case ID AOOTest-24 :: Version : 1
Table background bitmap fill

Rev. 1502185
Comment 1 Oliver-Rainer Wittmann 2013-10-07 11:06:00 UTC 
Reproduced the following behavior under Windows 7 64bit and Ubuntu 11.10 64bit:
- new presentation document
- insert table via menu Insert - Table
- place cursor inside a table cell
- select via keys Shift-Arrow Keys at least on table cell
- change table cell background via Table Toolbar to 'Bitmap - Water'
--> Table Toolbar does not show the selected table cell background.

I observed this in OOo 3.3.0, AOO 3.4.0, AOO 4.0.0 and AOO 4.0.1
--> platform = All
--> version = 3.4.0

@Edwin Sharp:
Is this the issue you are observing?
Comment 2 Edwin Sharp 2013-10-07 11:12:46 UTC 
Yes.
Comment 3 Armin Le Grand 2013-10-11 17:24:38 UTC 
ALG: Looks like a refresh problem
- assigment works
- after that, travelling in table makes the update work (even with multiselect, show nothing when not equal)
Only after direct assigmnent everything except color type goes back to the last color type (and also to the last assigned color even when changed to e.g. hatch style and a hatch).
Comment 4 Armin Le Grand 2013-10-15 13:51:39 UTC 
ALG: Refresh does not work, even in normal edit view
- new shape
- use toolbar to chaneg e.g. to gradient and select a gradient
->entries stay on last combination

Reason is that SvxFillToolBoxControl::IgnoreStatusUpdate is used in FillControl::SelectFillAttrHdl to suppress the change of the XFillStyleItem in SvxFillToolBoxControl::StateChanged. No idea why this was originally done, but it does not work.
Also seen: multiple executes will create two undo actions when using the toolbar change stuff, too, looking if this can also be adapted...
Comment 5 Armin Le Grand 2013-10-15 15:49:52 UTC 
ALG: Cannot do anything about the multiple changes when changing fill style and value, the uno api does not allow that with the slots in play; not too bad; there are two actions, same as in sidebar FillStyle panel, only that action is only taken when the value is changed.
The error itself can be cured by not suppressing the update as it was originally; checked with objects and within tables, all works well. Preparing commit...
Comment 6 SVN Robot 2013-10-15 15:51:03 UTC 
"alg" committed SVN revision 1532400 into trunk:
i122738 corrected update of FillStyle/FillAttribute UI elements
Comment 7 Armin Le Grand 2013-10-16 11:38:52 UTC 
ALG: Committed, done.
Comment 8 zhaoshzh 2014-04-09 03:29:15 UTC 
verified on AOO410m15(Build:9761)  -  Rev. 1585021
Comment 9 zhaoshzh 2014-04-09 07:29:32 UTC 
verified on 122738