Issue 122841 - AOO Calc 4.0 crashes when opening a Lotus 1-2-3 file
Summary: AOO Calc 4.0 crashes when opening a Lotus 1-2-3 file
Status: CLOSED FIXED
Alias: None
Product: Calc
Classification: Application
Component: open-import (show other issues)
Version: 4.0.0
Hardware: All Windows, all
: P3 Major (vote)
Target Milestone: 4.0.1
Assignee: hdu@apache.org
QA Contact:
URL:
Keywords: crash, regression
Depends on:
Blocks:
 
Reported: 2013-07-25 16:35 UTC by loraleahb
Modified: 2017-05-20 10:33 UTC (History)
6 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: 4.0.0
Developer Difficulty: ---
jsc: 4.0.1_release_blocker+

Attachments
Basic Lotus 1-2-3 (3.92 KB, application/octet-stream)
2013-07-29 15:04 UTC, loraleahb 		no flags Details
crash stack (961 bytes, text/plain)
2013-08-01 12:50 UTC, hdu@apache.org 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description loraleahb 2013-07-25 16:35:20 UTC 
AOO 4.0 Calc crashes when attempting to open a basic Lotus 1-2-3 file (.123).  Lotus 1-2-3 is still listed in the list of file types when performing a file open.  Should AOO 4.0 be able to open 1-2-3 files?  If not, then the file type needs to be removed.  Also, the application shouldn't completely crash, but offer an error message that it cannot open that file type.

Additionally, Writer and Impress are unable to open WordPro or Freelance files, but those file types are not listed in the File > Open list of types.
Comment 1 Edwin Sharp 2013-07-25 19:13:33 UTC 
Please attach .123 file.
Comment 2 loraleahb 2013-07-29 15:04:23 UTC 
Created attachment 81194 [details]
Basic Lotus 1-2-3

This and any other 1-2-3 file will crash AOO Calc 4.0.  Calc 3.3 could open the file.  Maybe 4.0 is not intended to open 1-2-3 files, but the file type is listed and it shouldn't crash the app.
Comment 3 Edwin Sharp 2013-07-29 15:47:13 UTC 
Thank you!

Crash with Rev. 1503704 Debian.

Attachment opens OK with Gnumeric 1.12.3.
Comment 4 hdu@apache.org 2013-08-01 12:50:27 UTC 
Created attachment 81228 [details]
crash stack

The global variable pLotusRoot is still NULL in frame #0 in LotAttrCache's constructor where it is derefenced. It is supposed to be initialized in ImportLotus's constructor (already running in frame #7) after the LOTUS_ROOT singleton has been created, but it is not available before.
Comment 5 SVN Robot 2013-08-01 13:14:41 UTC 
"hdu" committed SVN revision 1509224 into trunk:
#i122841# initialize LotusRoot singleton already in LotusRoot constructor
Comment 6 hdu@apache.org 2013-08-01 13:17:21 UTC 
The regression was introduced with revision 1362886 and fixed with the commit above.
Comment 7 jsc 2013-08-13 11:56:17 UTC 
approve showstopper request
Comment 8 SVN Robot 2013-08-13 13:49:51 UTC 
"hdu" committed SVN revision 1513489 into branches/AOO401:
#i122841# initialize LotusRoot singleton already in LotusRoot constructor
Comment 9 Edwin Sharp 2013-08-13 16:59:34 UTC 
IMHO not a release blocker.
Comment 10 fanyuzhen 2013-08-30 03:31:04 UTC 
It's verified fixed in AOO401m1(Build:9710)  -  Rev. 1516414