Issue 123480 - CRASH when delete contents in particular document with active 'Record Changes'
Summary: CRASH when delete contents in particular document with active 'Record Changes'
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: editing (show other issues)
Version: 4.0.0
Hardware: PC Windows 7
: P3 Major (vote)
Target Milestone: 4.1.0
Assignee: Oliver-Rainer Wittmann
QA Contact: zhaoshzh
URL:
Keywords: crash, regression
Depends on:
Blocks:
 
Reported: 2013-10-15 18:42 UTC by pichler
Modified: 2017-05-20 10:35 UTC (History)
5 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---
jsc: 4.1.0_release_blocker+


Attachments
File to reproduce the problem and the image showing the selected text before I type delete to crash the Writer application. (72.14 KB, application/x-rar-compressed)
2013-10-15 18:42 UTC, pichler
no flags Details
Test kit (33.34 KB, application/save-as)
2013-10-16 05:10 UTC, Rainer Bielefeld
no flags Details
Aoo freeze when click ctrl+z (171.52 KB, image/png)
2014-02-26 02:07 UTC, zhaoshzh
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description pichler 2013-10-15 18:42:13 UTC
Created attachment 81766 [details]
File to reproduce the problem and the image showing the selected text before I type delete to crash the Writer application.

In attachment there are two files.

One is a image showing I selecting all text before deleting, the OpenOffice crash after deleting it.

Also there are the file to reproduce de problem.

VERY IMPORTANT: The feature "record changes" must be enabled to crash be reproduced.
Comment 1 Rainer Bielefeld 2013-10-16 05:08:54 UTC
Reproducible with "AOO 4.0.1   – German UI / German locale  [Rev. 1524958 2013-09-20 11:40:29]" on  German WIN7 Home Premium (64bit)", “historic”  4.0  User Profile used for all  predecessor versions:

1. From AOO Start Center open reporter's sample document "problem.odt"
   > Caret flashes at top left end of first sheet
2. <control+a> to select all
3. [Del] key on keyboard
   CRASH

Additional info:
(a) no crash with 3.4.0, so REGRESSION

(b) Crash is related to active 'Edit -> Changes -> Record'. No crash if this
    function has been unchecked

(c) Already Reproducible with  server installation of  "AOO 4.0.0-Dev – English UI / German locale [AOO400m1(Build:9700) - Rev. 1479897 (2013-05-09)]" on German WIN7 Home Premium (64bit)", own separate user profile

(d) Was still ok  with server installation of  " AOO 4.0.0-Dev  – English UI / German locale [AOO400m1(Build:9700) - Rev. 1457992 – Rev.1457606  ((2013-03-19))]" on German WIN7 Home Premium (64bit)", own separate user profile

(e) Crash is related to changes history. I will attach a test kit with a simplified "problem2.odt", what still will crash, and a "problem20.odt", identical to "problem2.odt", but all changes accepted. "problem20.odt" no longer will crash

(f) currently only reproduced with 1 particular document, so "blocker" -> "major"

@pichler
Can you reproduce the problem with other documents and can you contribute a step by step instruction how to create a very simple document that reproduces the crash?
Comment 2 Rainer Bielefeld 2013-10-16 05:10:21 UTC
Created attachment 81767 [details]
Test kit

see comment above how to use
Comment 3 pichler 2013-10-16 11:08:43 UTC
@ranier I can't reproduce it, once I get a already done file.

It's a large document, a web service specification for private customers so I can't share it.

I removed all private information and let just the part of it that crashes the Writer.
Comment 4 pichler 2013-10-16 11:11:55 UTC
(In reply to Rainer Bielefeld from comment #2)
> Created attachment 81767 [details]
> Test kit
> 
> see comment above how to use

(In reply to Rainer Bielefeld from comment #1)
> Reproducible with "AOO 4.0.1   – German UI / German locale  [Rev. 1524958
> 2013-09-20 11:40:29]" on  German WIN7 Home Premium (64bit)", “historic”  4.0
> User Profile used for all  predecessor versions:
> 
> 1. From AOO Start Center open reporter's sample document "problem.odt"
>    > Caret flashes at top left end of first sheet
> 2. <control+a> to select all
> 3. [Del] key on keyboard
>    CRASH
> 
> Additional info:
> (a) no crash with 3.4.0, so REGRESSION
> 
> (b) Crash is related to active 'Edit -> Changes -> Record'. No crash if this
>     function has been unchecked
> 
> (c) Already Reproducible with  server installation of  "AOO 4.0.0-Dev –
> English UI / German locale [AOO400m1(Build:9700) - Rev. 1479897
> (2013-05-09)]" on German WIN7 Home Premium (64bit)", own separate user
> profile
> 
> (d) Was still ok  with server installation of  " AOO 4.0.0-Dev  – English UI
> / German locale [AOO400m1(Build:9700) - Rev. 1457992 – Rev.1457606 
> ((2013-03-19))]" on German WIN7 Home Premium (64bit)", own separate user
> profile
> 
> (e) Crash is related to changes history. I will attach a test kit with a
> simplified "problem2.odt", what still will crash, and a "problem20.odt",
> identical to "problem2.odt", but all changes accepted. "problem20.odt" no
> longer will crash
> 
> (f) currently only reproduced with 1 particular document, so "blocker" ->
> "major"
> 
> @pichler
> Can you reproduce the problem with other documents and can you contribute a
> step by step instruction how to create a very simple document that
> reproduces the crash?

I think this is blocker. I can't move on editing my large file where contains this part that crashes. I can't wait so I'm creating a new file and copy pasting everything and formatting again, so I can continue with my private software specification.
Comment 5 Rainer Bielefeld 2013-10-16 11:56:08 UTC
(In reply to pichler from comment #4)
> I think this is blocker.

Hi pichler, a problem of a single user with a single document definitively is not a blocker, please see it from project's point of view. 

Nevertheless, AOO never should crash.
Comment 6 pichler 2013-10-16 11:58:37 UTC
(In reply to Rainer Bielefeld from comment #5)
> (In reply to pichler from comment #4)
> > I think this is blocker.
> 
> Hi pichler, a problem of a single user with a single document definitively
> is not a blocker, please see it from project's point of view. 
> 
> Nevertheless, AOO never should crash.

Understood.
Comment 7 jsc 2013-10-16 15:38:12 UTC
I tried it on MacOS with the released AOO 4.0.1 and all 3 sample documents.

Moved in the upper left corner -> selct all -> press delete -> no crash
Repeat and set the curser in the header -> no crash

Means I can't reproduce on MacOS
Comment 8 Oliver-Rainer Wittmann 2014-01-15 10:21:12 UTC
taking over to work on a solution
Comment 9 SVN Robot 2014-01-17 07:28:18 UTC
"orw" committed SVN revision 1559037 into trunk:
123480: method <::sw::mark::deleteMarks(..)> - assure sorting of subset mark ...
Comment 10 Oliver-Rainer Wittmann 2014-01-17 07:29:46 UTC
fixed on trunk for the next release
Comment 11 zhaoshzh 2014-02-26 02:07:15 UTC
Created attachment 82707 [details]
Aoo freeze when click ctrl+z

Dev Snapshot Apache OpenOffice 4.1.0 - full installation sets
Comment 12 zhaoshzh 2014-02-27 03:02:34 UTC
test on AOO410m1(build:9750) - rev:1566593
Comment 13 Oliver-Rainer Wittmann 2014-02-27 09:30:33 UTC
My observation is the following on recent developer snapshot (rev. 1566593):
- Undo does not work, but no freeze.
- A further Redo followed by an Undo causes a freeze

--> reopening issue to correct the Undo.
--> requesting show-stopper status as a fix is needed
Comment 14 jsc 2014-02-27 10:06:07 UTC
grant showstopper flag
Comment 15 Oliver-Rainer Wittmann 2014-02-27 11:20:56 UTC
working on a solution for the defects of the Undo/Redo.
Comment 16 SVN Robot 2014-02-27 14:00:06 UTC
"orw" committed SVN revision 1572577 into trunk:
123480: assure correct Undo/Redo with not shown tracked changes
Comment 17 SVN Robot 2014-02-27 14:20:55 UTC
"orw" committed SVN revision 1572589 into branches/AOO410:
123480: assure correct Undo/Redo with not shown tracked changes
Comment 18 Oliver-Rainer Wittmann 2014-02-27 14:25:35 UTC
The defect found during fix verification (comment #11 and comment #13) is a related issue which had been introduced in OOo 3.4 Beta:
- Undo/Redo of a certain text deletion does not work when changes had been recorded/tracked and these changes are not shown.

Fixed for next release on trunk and on release branch AOO410
Comment 19 Oliver-Rainer Wittmann 2014-03-04 08:49:54 UTC
certain made refactorings are wrong
--> reopened to correct the code
Comment 20 SVN Robot 2014-03-04 14:10:26 UTC
"orw" committed SVN revision 1574101 into trunk:
123480: correct the previous made refactoring (revision 1572577)
Comment 21 SVN Robot 2014-03-04 14:33:58 UTC
"orw" committed SVN revision 1574109 into branches/AOO410:
123480: correct the previous made refactoring (revision 1572589)
Comment 22 Oliver-Rainer Wittmann 2014-03-04 14:37:29 UTC
Fixed refactoring mistake for next release on trunk and on release branch AOO410
Comment 23 jsc 2014-04-02 15:03:03 UTC
verified with AOO 4.1 RC on MacOS and Windows

AOO410m15(Build:9761)  -  Rev. 1583666
2014-04-01 13:46:49 (Tue, 01 Apr 2014)