Issue 124231 - named range with visibility condition can crash writer
Summary: named range with visibility condition can crash writer
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: ui (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: All Windows, all
: P3 Major (vote)
Target Milestone: 4.1.1
Assignee: Oliver-Rainer Wittmann
QA Contact:
URL:
Keywords: crash
Depends on:
Blocks:
 
Reported: 2014-02-13 16:28 UTC by Oliver Brinzing
Modified: 2017-05-20 10:35 UTC (History)
8 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: 4.1.0
Developer Difficulty: ---
jsc: 4.1.1_release_blocker+


Attachments
hide range crash demo (9.56 KB, application/vnd.oasis.opendocument.text)
2014-02-13 16:28 UTC, Oliver Brinzing
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description Oliver Brinzing 2014-02-13 16:28:07 UTC
Created attachment 82584 [details]
hide range crash demo

steps to reproduce:
- open attached writer document
- double click on userfield X_TEXT (value <X_TEXT>
- remove value text <X_TEXT> from userfield X_TEXT
- press green check mark
- press [OK] to close the dialog

btw: the table is inside a named range (X_RANGE) 
with visible condition: X_TEXT eq ""
Comment 1 Oliver Brinzing 2014-02-13 16:28:50 UTC
adding crash tag
Comment 2 Edwin Sharp 2014-02-13 16:44:31 UTC
No crash
AOO410m1(Build:9750)  -  Rev. 1565724
Rev.1565724
Win 7
Comment 3 Oliver Brinzing 2014-02-13 17:00:13 UTC
i tested with aoo rev 1565510 on win 7 64bit.

after: "press green check mark"
the table should hide in background of the input dialog. 
if this happens, aoo will crash after [OK].
but it seems aoo does not update (hide) the table every time.
seems to be a refresh problem too.
Comment 4 Edwin Sharp 2014-02-13 18:16:03 UTC
This is what I did:

http://screencast.com/t/OnzH5vVzS0hM
Comment 5 Oliver Brinzing 2014-02-14 06:45:24 UTC
>http://screencast.com/t/OnzH5vVzS0hM
in your case the table is still visible after deleting the value.
if this happens, aoo seems not to crash.
Comment 6 jolatt 2014-02-14 08:28:20 UTC
(In reply to brinzing from comment #5)
> >http://screencast.com/t/OnzH5vVzS0hM
> in your case the table is still visible after deleting the value.

table disappears pressing F9
Comment 7 Edwin Sharp 2014-02-16 13:30:15 UTC
No crash
AOO410m1(Build:9750)  -  Rev. 1566800
2014-02-11_04:11:01 - Rev. 1566981
Debian
Comment 8 Oliver-Rainer Wittmann 2014-02-17 20:05:33 UTC
status is somehow unclear to me.
- Is the issue reproducible or not?
Comment 9 Oliver-Rainer Wittmann 2014-02-17 20:24:29 UTC
I can confirmed the crash myself on Windows 7 using OOo 3.0.0 and AOO 4.0.1.

To reproduce it I need to changes to the User Field's content and apply the change (click on green check mark) before I set it to empty.
Comment 10 Oliver-Rainer Wittmann 2014-02-17 20:26:56 UTC
Just a minor note:
The given use case is a little bit theoretically, because after the section is hidden it will be quite hard for the user to bring it back.
Comment 11 Oliver-Rainer Wittmann 2014-02-17 20:31:41 UTC
(In reply to Oliver-Rainer Wittmann from comment #9)
> I can confirmed the crash myself on Windows 7 using OOo 3.0.0 and AOO 4.0.1.
> 
> To reproduce it I need to changes to the User Field's content and apply the
> change (click on green check mark) before I set it to empty.

I can also reproduce the defect when I update the fields (Menu Tools - Update - Fields or Key F9) before I open the User Field's dialog.
Comment 12 Oliver Brinzing 2014-07-16 04:16:27 UTC
is it possible to fix this issue in aoo 4.1.1?
Comment 13 jolatt 2014-07-16 07:02:54 UTC
with AOO411m2(Build:9771)  -  Rev. 1608452:

- delete the User Fields content
- "press green check mark"  table disappears
- hit O.K. -> crash

If you hit O.K. directly after deleting the user fields content, table disappears -> no crash

I tried it it about ten times always with the same behavior.

BTW, changing the User Fields content before deleting (Comment 9) has no effect on the described behavior.
Further I cannot reproduce the behavior described in Comment 11.

OS: Ubuntu 14.04
Comment 14 Oliver-Rainer Wittmann 2014-07-16 14:03:28 UTC
taking over to have a closer look.
let us see, if a solution for planned 4.1.1 release is possible.
Comment 15 SVN Robot 2014-07-18 07:54:05 UTC
"orw" committed SVN revision 1611549 into trunk:
124231: field variable dialog: check access to current field as it could be u...
Comment 16 Oliver-Rainer Wittmann 2014-07-18 07:57:34 UTC
fixed on trunk

from my point of view the fix should be considered for the planned 4.1.1 release
Comment 17 jsc 2014-07-18 08:06:25 UTC
grant showstopper flag, fix available
Comment 18 SVN Robot 2014-07-18 08:32:40 UTC
"orw" committed SVN revision 1611555 into branches/AOO410:
124231: field variable dialog: check access to current field as it could be u...
Comment 19 Oliver-Rainer Wittmann 2014-07-18 08:36:37 UTC
fixed on branch AOO410 for the planned 4.1.1 release.
Comment 20 fanyuzhen 2014-07-18 10:13:16 UTC
Current available build AOO 4.1.1 M2(AOO411m2(Build:9771)  -  Rev. 1608452
2014-07-07 15:29:02 (Mon, 07 Jul 2014)) doesn't include the fix, waiting for next build(M3) for verification
Comment 21 Pedro 2014-07-21 21:22:30 UTC
Fixed in AOO411m3(Build:9772)  -  Rev. 1611634 (tested under Win 7 SP1 x64)
The table is hidden as expected. There is no crash.
Comment 22 jolatt 2014-07-21 22:25:39 UTC
(In reply to Pedro from comment #21)
> Fixed in AOO411m3(Build:9772)  -  Rev. 1611634 (tested under Win 7 SP1 x64)
> The table is hidden as expected. There is no crash.

Same with Ubuntu 14.04.
Comment 23 fanyuzhen 2014-07-24 05:49:04 UTC
Thanks Pedro and Jolatt for your verification. I mark this bug as Verification / Fixed based on their test results in comment 21 and 22
Comment 24 Oliver Brinzing 2014-07-25 14:22:17 UTC
seems to be fixed in aoo 4.1.1m3  rev. 1612804

but dialog behaves quite strange:

- double click on userfield X_TEXT (value <X_TEXT>
- remove value text <X_TEXT> from userfield X_TEXT
- press green check mark
-> table is hidden
-> but cursor still blinks and green check mark is not disabled

now enter some text and press green check mark again
-> green check mark is disabled
->"Name" field ("X_TEST") is empty
-> "OK" button is disabled
- press "Cancel"
-> new value is set, but table is still hidden
- press F9 to refresh fields
-> table will be shown