Issue 124389 - Undo-Redo after Text input decreases multi line Table row height to single line
Summary: Undo-Redo after Text input decreases multi line Table row height to single line
Status: CLOSED FIXED
Alias: None
Product: Draw
Classification: Application
Component: editing (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: All All
: P3 Normal (vote)
Target Milestone: 4.2.0
Assignee: Armin Le Grand
QA Contact:
URL:
Keywords:
: 124390 (view as issue list)
Depends on:
Blocks:
 
Reported: 2014-03-10 06:20 UTC by Clarence GUO
Modified: 2017-05-20 10:35 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: 4.1.0-beta
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Clarence GUO 2014-03-10 06:20:48 UTC 
1) Create a impress document and insert a table
2) Input several lines in a cell of the table. The height of the cell will be increased correspondingly
3) Set focus out of the impress table
4) Undo once, now the height of the cell which have multi-lines just now change to height of one line
5) Redo once.

Expect: The height of the cell which have multi-lines just now should change to multi-lines
Defect: The height of the cell is still one line.

Test ENV:
Build 1571942
Window 7 Professional SP1 64 bit
Comment 1 Edwin Sharp 2014-03-10 07:10:49 UTC 
Text is obscured by table.
AOO410m14(Build:9760)  -  Rev. 1573062
2014-03-01_04:11:01 - Rev. 1573123
Debian
Comment 2 hdu@apache.org 2014-03-10 07:53:05 UTC 
*** Issue 124390 has been marked as a duplicate of this issue. ***
Comment 3 Oliver-Rainer Wittmann 2014-03-10 10:06:23 UTC 
I can confirm the described behavior in OOo 3.2.1, OOo 3.3.0, AOO 3.4.0 and AOO 4.0.0, works fine in OOo 3.0.0
Comment 4 Rainer Bielefeld 2014-03-12 09:53:34 UTC 
(a) Reproducible with "AOO 4.0.1 Release – German UI / German locale 
    [AOO401m5(Build:9714)  -  Rev. 1524958 2013-09-20 11:40:29]" on 
    German WIN7 Home Premium (64bit)", “historic” 4.0 User Profile 
    used for all predecessor versions: After redo row height is reduced to
    single text line. Following Text lines hidden behind table
(b) As expected the same in DRAW
(c) It does not matter whether multi-paragraphs or multi lines by auto wrap.
(d) Similar effect with LibO 4.2
Comment 5 SVN Robot 2014-03-26 11:54:52 UTC 
"alg" committed SVN revision 1581793 into trunk:
i124389 for tables refresh TextFrame when OutlinerParaObject changes
Comment 6 Armin Le Grand 2014-03-26 11:55:05 UTC 
Happens since in SdrTextObj::NbcSetOutlinerParaObjectForText for the object being a SdrTableObj no NbcAdjustTextFrameWidthAndHeight is called since IsTextFrame() is false for that object type. Thinking about how to fix that. Indeed a table is no text frame, but uses AutoGrow in width and height and thus needs relayouts of that kind. Need to add this...
Comment 7 Armin Le Grand 2014-03-26 11:55:32 UTC 
Added, done.
Comment 8 Armin Le Grand 2014-03-26 12:40:44 UTC 
Have to reopen, the place I fixed it is in principle correct, but makes the runtime to create tables (and other ops on them) very slow; the handling is correct, but has too much overhead. I will need to make an explicit change for the Undo/Redo functionality, instead of a general one...
Comment 9 Armin Le Grand 2014-03-26 12:49:01 UTC 
Corrected to strictly only relayout TextFrame in Undo/Redo, works as expected, comitting.
Comment 10 Armin Le Grand 2014-03-26 12:49:49 UTC 
Okay, done.
Comment 11 SVN Robot 2014-03-26 12:55:58 UTC 
"alg" committed SVN revision 1581814 into trunk:
i124389 correct TextFrame layout for tables not when new text is set, but in ...