Issue 124497 - When applying interactive crop actions the Undo comment contains '%O' statements
Summary: When applying interactive crop actions the Undo comment contains '%O' statements
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: ui (show other issues)
Version: 4.1.0-beta
Hardware: All All
: P3 Normal (vote)
Target Milestone: 4.2.0
Assignee: Armin Le Grand
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-24 11:11 UTC by Armin Le Grand
Modified: 2017-05-20 10:35 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Armin Le Grand 2014-03-24 11:11:17 UTC 
- New Draw/Impress
- insert graphic object (e.g. any shape, convert to bitmap)
- start interactive cropping (Picture toolbar, 'Crop Picture' button)
- Do some cropping
- Open Undo stack (top toolbar)
-> Stack contains 'Crop %O' statements

Already the same in AOO401, so no regression.
Something like '%O' is a hint that some string exchange in creating the Undo action is not done; it will need evaluation if and what was/is intended to be exchanged for %O originally.
Comment 1 Armin Le Grand 2014-03-24 11:48:11 UTC 
Investigation shows that '%O' was used for object description in older versions, there was a change to adapt these placeholders in resource strings by %1, %2 etc. for more uniqueness. Looks as if that string was overseen (or added after that change from a CWS). Checked if it's okay if I patch the string, looks good. I Will change '%O' to '%1'...
Comment 2 SVN Robot 2014-03-24 11:49:25 UTC 
"alg" committed SVN revision 1580818 into trunk:
i124497 Corrected object description placeholder from %O to %1
Comment 3 Armin Le Grand 2014-03-24 11:49:51 UTC 
Okay, done.