Issue 125143 - helpex Export::CopyFile is too slow
Summary: helpex Export::CopyFile is too slow
Status: CLOSED FIXED
Alias: None
Product: Internationalization
Classification: Code
Component: helpcontent (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: All All
: P3 Normal (vote)
Target Milestone: 4.1.1
Assignee: hdu@apache.org
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-23 12:43 UTC by hdu@apache.org
Modified: 2017-05-20 10:35 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: 4.2.0-dev
Developer Difficulty: ---
jsc: 4.1.1_release_blocker+


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description hdu@apache.org 2014-06-23 12:43:12 UTC
Building the helpcontent2 module takes many minutes, especially when WITH_LANG is active. Tracing the build progress shows that the seemingly simple function CopyFile() takes a significant amount of time. Looking at the relevant code there is some copying of single lines going on, which could be replaced by something much faster.
Comment 1 SVN Robot 2014-06-23 12:48:28 UTC
"hdu" committed SVN revision 1604786 into trunk:
#i125143# use bulk-copying instead of line-wise in helpex Export::CopyFile()
Comment 2 hdu@apache.org 2014-06-23 12:50:18 UTC
Fixed with the commit above. It has been measured to reduce the time per language by about 30%.
Comment 3 SVN Robot 2014-06-24 09:48:21 UTC
"hdu" committed SVN revision 1605044 into trunk:
#i125143# reduce helpex stack usage to prevent intermittent failures
Comment 4 hdu@apache.org 2014-07-07 08:33:41 UTC
With so many languages in our releases and even more for AOO 4.1.1 such speedups for each language may help in the release process, so we should consider to merge the fix into the release branch.
Comment 5 jsc 2014-07-07 08:41:19 UTC
grant showstopper flag

not directly related for the release but a huge improvement to speed up the release preparation
Comment 6 SVN Robot 2014-07-07 08:50:37 UTC
"hdu" committed SVN revision 1608366 into branches/AOO410:
#i125143# speedup helpex by using bulk-copy instead of doing it line-wise