Issue 125325 - [SVG] Cannot handle style sheet comments
Summary: [SVG] Cannot handle style sheet comments
Status: CLOSED FIXED
Alias: None
Product: Draw
Classification: Application
Component: code (show other issues)
Version: 4.2.0-dev
Hardware: PC Windows 7
: P3 Normal (vote)
Target Milestone: 4.2.0
Assignee: Armin Le Grand
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-29 21:45 UTC by Regina Henschel
Modified: 2017-05-20 10:35 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
file with /*comment*/ in style sheet (759 bytes, image/svg+xml)
2014-07-29 21:45 UTC, Regina Henschel 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Regina Henschel 2014-07-29 21:45:40 UTC 
Created attachment 83749 [details]
file with /*comment*/ in style sheet

The test case styling-css-04-f.svg from the W3C_SVG_11_TestSuite cannot run, because the frame rectangle is filled and covers the test results.

I have pinpoint the problem to this: AOO cannot handle comments in style sheets. A style sheet comment is written as /*comment*/, for details see http://www.w3.org/wiki/CSS_basics or the spec itself in http://www.w3.org/TR/CSS2/syndata.html#comments

Insert the attached file into a Draw document. The right rectangle should be without filling, but it has the default black filling.
Comment 1 Armin Le Grand 2014-07-30 11:00:34 UTC 
Grepping for reference. Should be straight forward.
Comment 2 SVN Robot 2014-10-10 15:52:52 UTC 
"alg" committed SVN revision 1630928 into trunk:
i125325 added code to handle block comments in Css style definitions
Comment 3 Armin Le Grand 2014-10-10 15:53:21 UTC 
Okay, added needed code, checked, done.