Apache OpenOffice (AOO) Bugzilla – Issue 125400
CJK numbering ordered list fallback to Arabic numerals
Last modified: 2023-03-02 15:25:28 UTC
Created attachment 83808 [details] Original numbering in a docx file in MSO Chinese numbering in docx fallback to Arabic numerals. This issue is specific to the docx files created by traditional Chinese version of MSO that were used in taiwan. More specifically, taiwaneseCountingThousand of w:numfmt attribute in ooxml is ignored.
Created attachment 83809 [details] Chinese numbering fallback to Arabic numerals in AOO
Created attachment 83810 [details] Test case.
Created attachment 83811 [details] Patch for fixing the issue.
Created attachment 83840 [details] Patch to filters for Chinese(ZH-TW) numbering issues
Created attachment 83841 [details] Patch for Chinese(ZH-TW) numbering issues Check 'patch' field. Following Chinese(ZH-TW) issues were fixed: * RTF import * doc import and export * docx import
(In reply to Mark Hung from comment #5) > Created attachment 83841 [details] > Patch for Chinese(ZH-TW) numbering issues > > Check 'patch' field. Following Chinese(ZH-TW) issues were fixed: > > * RTF import > * doc import and export > * docx import Hi Mark, I applied your patch and found that the issue was not fixed. Can you check it?
(In reply to Steve Yin from comment #6) > (In reply to Mark Hung from comment #5) > > Created attachment 83841 [details] > > Patch for Chinese(ZH-TW) numbering issues > > > > Check 'patch' field. Following Chinese(ZH-TW) issues were fixed: > > > > * RTF import > > * doc import and export > > * docx import > > Hi Mark, > > I applied your patch and found that the issue was not fixed. Can you check > it? Sorry, I mixed it up with i125495. This patch works.
There are two cases which cannot identify ZH-TW and ZH-CN. It seems that a new definition is needed.
Created attachment 83890 [details] Patch for Chinese(ZH-TW) numbering issues * RTF import * RTF export * doc import and export * docx import Update supports to RTF export. Also export SVX_NUM_NUMBER_LOWER_ZH based on application language setting. Map to 39 if LANGUAGE_CHINESE_SIMPLIFIED and 35 otherwise. Note that there are several Chinese numbering type in MSO that has minor difference, and is not implemented in AOO. For example, a circle that represent zero were used in some cases. They are inevitably all mapped to SVX_NUM_NUMBER_LOWER_ZH and are not able to mapped back again. So I'd advice to accept current implementation unless any side effects are found. If it is possible to find Japanese testers, we can improve it further. They are all the same.
(In reply to Mark Hung from comment #9) > Created attachment 83890 [details] > Patch for Chinese(ZH-TW) numbering issues > > > * RTF import > * RTF export > * doc import and export > * docx import > > Update supports to RTF export. Also export SVX_NUM_NUMBER_LOWER_ZH based on > application language setting. Map to 39 if LANGUAGE_CHINESE_SIMPLIFIED and > 35 otherwise. > > Note that there are several Chinese numbering type in MSO that has minor > difference, and is not implemented in AOO. For example, a circle that > represent zero were used in some cases. They are inevitably all mapped to > SVX_NUM_NUMBER_LOWER_ZH and are not able to mapped back again. So I'd advice > to accept current implementation unless any side effects are found. > > If it is possible to find Japanese testers, we can improve it further. They > are all the same. Thanks for fixing RTF export. I found the patch did not work for docx import.
I will also have a look at this issue.
Created attachment 83894 [details] Explain for the test case. Note that improvement for docx import is only for LOWER_NUMBER_ZH and FULL_WIDTH_NUMBER.
Created attachment 83900 [details] Complete test cases explain
Created attachment 83901 [details] All test cases(zipped)
@Oliver: any comments?
See also https://issues.apache.org/ooo/show_bug.cgi?id=69855
Created attachment 83968 [details] Patch for CJK numbering issues. This patch includes Japanese & Korean numbering.
Hi Developers, What's happening? Is there anyone working on verifying or merging the patch? Do I need to improve anything or provide any information in order to get it merged?
(In reply to Mark Hung from comment #18) > Hi Developers, > > What's happening? > Is there anyone working on verifying or merging the patch? > Do I need to improve anything or provide any information > in order to get it merged? Hi Mark, Sorry for the late reply. Something changes in the community... I will check them in. Thank you for your contribution again!
hi Steve, Thank you. After months passed, I've done submitting similar fix to LibreOffice https://gerrit.libreoffice.org/#/c/12252/ I'd like to take some time to update patch I submitted here, especially for coding style and differentiating simplified Chinese and traditional Chinese. Would you suggest that I just obsolte patch here, or wait for you to merge the code first?
(In reply to Mark Hung from comment #20) > hi Steve, > > Thank you. After months passed, I've done submitting similar fix to > LibreOffice > > https://gerrit.libreoffice.org/#/c/12252/ > > I'd like to take some time to update patch I submitted here, especially for > coding style and differentiating simplified Chinese and traditional Chinese. > Would you suggest that I just obsolte patch here, or wait for you to merge > the code first? Hi Mark, I found that you and other contributors made some improvements on this patch. So my suggestion is that you can obsolete the old patch and update a new patch. Then I will deliver your latest patch in the trunk. Thanks.
Created attachment 84246 [details] Patch for fixing CJK numbered list. Update patch. This patch differs from previous patches in (a)code clean up (b)Export NUMBER_LOWER_ZH as differnt values of Simplified Chinese or Traditional Chinese based on language setting.
Hi Mark, Thanks. I will take care of it. :)
The patch is OK. UT passed.
"steve_y" committed SVN revision 1642310 into trunk: Issue 125400 - CJK numbering ordered list fallback to Arabic numerals
Cherry-picked for AOO41X with: https://github.com/apache/openoffice/commit/c43a074bcb3028e78ea20162afdadb1ff1448427