Issue 126118 - malformed make conditions in /vcl/Module_vcl.mk
Summary: malformed make conditions in /vcl/Module_vcl.mk
Status: RESOLVED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: dmake (show other issues)
Version: 4.2.0-dev
Hardware: PC Linux, all
: P5 (lowest) Normal (vote)
Target Milestone: 4.2.0
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-19 23:05 UTC by Kay
Modified: 2015-09-07 22:04 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: 4.2.0-dev
Developer Difficulty: ---

Attachments
Patch to change ifndef statements to ifdef in this makefile. (615 bytes, patch)
2015-02-19 23:05 UTC, Kay 		kschenk: review?
Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Kay 2015-02-19 23:05:36 UTC 
Created attachment 84515 [details]
Patch to change ifndef statements to ifdef in this makefile.

Operating environment: openSUSE 12.3
GNU Make 3.82

ifndef conditions in /vcl/Module_vcl.mk not processed.

Even though --enable-gtk specified, gtk plugin not built. Porecessing of --

ifneq ($(ENABLE_GTK),)

construct seems to be non-operable with current GNU make version of 3.82.

Patch to change the logic for this statement and similar for KDE statements.

Only the GTK option has been built and verified that vcl-gtk plugin is now being built.
Comment 1 Kay 2015-03-03 21:50:31 UTC 
Comment on attachment 84515 [details]
Patch to change ifndef statements to ifdef in this makefile.

Need review for this patch on all platforms.
Comment 2 Kay 2015-03-03 21:59:20 UTC 
Comment on attachment 84515 [details]
Patch to change ifndef statements to ifdef in this makefile.

set flag incorrectly before. Reset to "request" not granted.
Comment 3 Kay 2015-03-22 21:28:47 UTC 
Changes committed with rev 1667884