Issue 127087 - Build 1756954 includes outdated English dictionary
Summary: Build 1756954 includes outdated English dictionary
Status: CLOSED FIXED
Alias: None
Product: Installation
Classification: Application
Component: code (show other issues)
Version: 4.2.0-dev
Hardware: All Windows, all
: P5 (lowest) Normal (vote)
Target Milestone: 4.2.0
Assignee: Andrea Pescetti
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-24 12:57 UTC by Pedro
Modified: 2016-08-25 20:08 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Pedro 2016-08-24 12:57:16 UTC 
The daily/nightly Windows installer includes the 2015.10.01 English dictionary.

After install Extension Manager offers version 2016.05.01

Version 2016.07.01 is available from Extensions
http://extensions.openoffice.org/en/project/english-dictionaries-apache-openoffice

I assume that the installer builder should check and include the latest version available for each language.
Comment 1 SVN Robot 2016-08-25 18:27:53 UTC 
"pescetti" committed SVN revision 1757745 into trunk:
#i127087# Update English dictionary to version 2016.07.01.
Comment 2 Andrea Pescetti 2016-08-25 18:33:40 UTC 
The version of the English dictionary to be included is specified manually in the code. It should stay like this since we do not know when the source code will be built (and we want the extensions to be the same version; for the English dictionary this does not make a big difference, but in principle you always want to specify an explicit version for bundled extensions).

I've now updated the English dictionary to its latest (2016.07.01) release in extensions.lst ; note that updating the file is easy, so if you see other dictionaries falling behind you can easily attempt to update the file (or a patch) if you have time. You can find/download the file from the link above.
Comment 3 Pedro 2016-08-25 19:32:32 UTC 
Hi Andrea

(In reply to Andrea Pescetti from comment #2)
> I've now updated the English dictionary to its latest (2016.07.01) release
> in extensions.lst ; note that updating the file is easy, so if you see other
> dictionaries falling behind you can easily attempt to update the file (or a
> patch) if you have time. You can find/download the file from the link above.

Can you update the file at line 138 to

# Portuguese (European).
[ language=pt || language=pt_PT ]
    57b12ab5d523711198c0f32dc37ecca6 http://sourceforge.net/projects/aoo-extensions/files/1196/38/oo3x-pt-pt-16.7.4.1.oxt/download "oo3x-pt-pt-16.7.4.1.oxt"

I have no idea how to update the file or submit a patch. Thanks!
Comment 4 SVN Robot 2016-08-25 20:05:09 UTC 
"pescetti" committed SVN revision 1757751 into trunk:
#i127087# Update Portuguese dictionary to version 16.7.4.1
Comment 5 Andrea Pescetti 2016-08-25 20:08:56 UTC 
Committed, thanks!

As for updating the file in future, you can just download it from
https://svn.apache.org/viewvc/openoffice/trunk/main/extensions.lst?view=markup
click on the "download" link, modify it and attach the file to any issue (put me in CC in case).

The third part ("dict-pt.oxt") of a line must always stay the same, since at build time the MD5 hash will be computed to see if the file needs to be downloaded again. This is why we settle on a "canonical" name for each dictionary, independent of the version.