Issue 128128 - Lost translations in database wizard
Summary: Lost translations in database wizard
Status: RESOLVED FIXED
Alias: None
Product: Internationalization
Classification: Code
Component: code (show other issues)
Version: 4.2.0-dev
Hardware: All All
: P5 (lowest) Normal (vote)
Target Milestone: 4.2.0
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2019-06-11 11:37 UTC by Matthias Seidel
Modified: 2019-06-21 19:53 UTC (History)
2 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
German database wizard showing English text (21.82 KB, image/png)
2019-06-11 11:37 UTC, Matthias Seidel
no flags Details
French database wizard showing English text (21.69 KB, image/png)
2019-06-11 11:39 UTC, Matthias Seidel
no flags Details
Proposed patch for double slashes (1.22 KB, patch)
2019-06-14 21:21 UTC, Matthias Seidel
no flags Details | Diff
Proposed patch for path to localize.sdf (884 bytes, patch)
2019-06-14 21:38 UTC, Matthias Seidel
no flags Details | Diff
Proposed patch for double slashes (1.37 KB, patch)
2019-06-15 07:01 UTC, Matthias Seidel
no flags Details | Diff
Proposed patch for path to localize.sdf (1020 bytes, patch)
2019-06-15 07:03 UTC, Matthias Seidel
no flags Details | Diff
German database wizard now showing translated text (21.84 KB, image/png)
2019-06-21 19:52 UTC, Matthias Seidel
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description Matthias Seidel 2019-06-11 11:37:45 UTC
Created attachment 86698 [details]
German database wizard showing English text

Some parts of the database wizard have lost their translation.
The strings are all localized and in Pootle/SDF.

It seems only one file is affected:
http://svn.apache.org/repos/asf/openoffice/trunk/main/dbaccess/source/ui/dlg/AutoControls_tmpl.hrc

This is a regression, 4.1.x shows localized text.
Comment 1 Matthias Seidel 2019-06-11 11:39:09 UTC
Created attachment 86699 [details]
French database wizard showing English text
Comment 2 oooforum (fr) 2019-06-12 10:58:02 UTC
Hallo Matthias,

I don't understand how this file is linked with Pootle translation.
I see that english strings are tagged by Text[ en-US ]  = "";

Did we added other language like:
Text[ fr-FR ] or Text [ de-DE ]
Comment 3 Matthias Seidel 2019-06-12 13:47:43 UTC
(In reply to oooforum (fr) from comment #2)
> Hallo Matthias,
> 
> I don't understand how this file is linked with Pootle translation.
> I see that english strings are tagged by Text[ en-US ]  = "";
> 
> Did we added other language like:
> Text[ fr-FR ] or Text [ de-DE ]

No, the source code contains only en-US strings.

See also (a bit outdated):
https://wiki.openoffice.org/wiki/Translation:General_Information

All strings are localized in Pootle and in SDF, the problem is that they don't get in this specific file during build.
Comment 4 Matthias Seidel 2019-06-12 22:12:49 UTC
Some lines from the log file:

R=e:/slave14/aoo-w741x/build && O=$R/main/solver/420/wntmsci12.pro && W=$R/main/solver/420/wntmsci12.pro/workdir && S=$R/main &&  PATH="${PATH}:$O/bin" $O/bin/transex3.exe -p svx -i $S/dbaccess/source/ui/dlg/AutoControls_tmpl.hrc -o $W/inc/dbaccess/AutoControls.hrc -m $R/extras/l10n/wntmsci12.pro/misc/sdf//dbaccess/inc/localize.sdf -l all
Warning : Can't open e:/slave14/aoo-w741x/build/extras/l10n/wntmsci12.pro/misc/sdf//dbaccess/inc/localize.sdf

It seems the path to sdf is wrong. I wonder, where the double slashes come from?
Comment 5 Matthias Seidel 2019-06-13 09:45:41 UTC
In:

https://svn.apache.org/repos/asf/openoffice/branches/AOO42X/main/solenv/gbuild/AllLangResTarget.mk

gb_SrsPartMergeTarget_SDFLOCATION is defined with a trailing slash:

gb_SrsPartMergeTarget_SDFLOCATION := $(LOCDIR)/l10n/$(INPATH)/misc/sdf/

which then results in double slashes in:

https://svn.apache.org/repos/asf/openoffice/branches/AOO42X/main/dbaccess/AllLangResTarget_dbui.mk

I will provide a patch if my test build is successful.
Comment 6 Matthias Seidel 2019-06-14 19:55:55 UTC
Even with corrected slash the path to the sdf is not correct.

The code looks for:
extras/l10n/wntmsci12.pro/misc/sdf/dbaccess/inc/localize.sdf

But the translations for AutoControls_tmpl.hrc are in:
extras/l10n/wntmsci12.pro/misc/sdf/dbaccess/source/ui/dlg/localize.sdf
Comment 7 Matthias Seidel 2019-06-14 21:21:08 UTC
Created attachment 86700 [details]
Proposed patch for double slashes
Comment 8 Matthias Seidel 2019-06-14 21:25:33 UTC
The same for toolbox_tmpl.hrc, the code looks for:
extras/l10n/wntmsci12.pro/misc/sdf/dbaccess/inc/localize.sdf

But the translations are in:
extras/l10n/wntmsci12.pro/misc/sdf/dbaccess/source/ui/inc/localize.sdf
Comment 9 Matthias Seidel 2019-06-14 21:38:23 UTC
Created attachment 86701 [details]
Proposed patch for path to localize.sdf
Comment 10 Matthias Seidel 2019-06-15 07:01:33 UTC
Created attachment 86702 [details]
Proposed patch for double slashes
Comment 11 Matthias Seidel 2019-06-15 07:03:13 UTC
Created attachment 86703 [details]
Proposed patch for path to localize.sdf
Comment 12 Matthias Seidel 2019-06-18 10:55:50 UTC
Patches committed with r1861567 to trunk and merged with r1861568 to AOO42x.
Comment 13 Matthias Seidel 2019-06-21 19:52:57 UTC
Created attachment 86705 [details]
German database wizard now showing translated text
Comment 14 Matthias Seidel 2019-06-21 19:53:54 UTC
Fixed (see attachment).