Issue 128489 - rendering for extrusion depth of custom shapes is wrong for position values other than zero
Summary: rendering for extrusion depth of custom shapes is wrong for position values o...
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: PC Windows 10
: P5 (lowest) Normal (vote)
Target Milestone: 4.1.12
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-21 22:19 UTC by Regina Henschel
Modified: 2022-10-28 12:56 UTC (History)
2 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: 4.1.11
Developer Difficulty: ---

Attachments
patch to fix the problem (1.06 KB, patch)
2021-10-21 22:19 UTC, Regina Henschel 		no flags Details | Diff
Screenshot how it should be rendered (19.48 KB, image/png)
2021-10-23 00:18 UTC, Regina Henschel 		no flags Details
File from which the screenshot is taken. (12.68 KB, application/vnd.oasis.opendocument.presentation)
2021-10-23 00:21 UTC, Regina Henschel 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Regina Henschel 2021-10-21 22:19:34 UTC 
Created attachment 87062 [details]
patch to fix the problem

I have fixed the problem for LibreOffice, see https://gerrit.libreoffice.org/c/core/+/123997 and  https://bugs.documentfoundation.org/show_bug.cgi?id=145245

AOO has the same problem. Attached is the patch as it would be needed for LibreOffice. I have no AOO source to generate a direct patch. But it contains only the correction of two wrong signs, so it should be no technical problem to transport it to AOO. You can use my patch under Apache License 2.0.
Comment 1 Marcus 2021-10-22 22:13:42 UTC 
@Regina:
Thank your for your patch. Do you have also some tips how to test the patched code?
Comment 2 Regina Henschel 2021-10-23 00:18:05 UTC 
(In reply to Marcus from comment #1)
> @Regina:
> Thank your for your patch. Do you have also some tips how to test the
> patched code?

Manually testing is easy. Take the example file from gerrit or from the LO bug and open it in current AOO and then in the patched one. The file contains extruded shapes with depth position 0, 0.5 and 1. The shapes are rotated by 90deg around the x-axis so that the extrusion becomes visible. The length of the extrusion should be the same. The position of the extrusion should be different.

I don't know how automatic testing is done for AOO. For the text with Cppunit in LO I have examined the bound rectangle of the shapes. In case depth position 0.5 the bound rectangle has height 0 in the unpatched Office, in case depth position 1 the bound rectangle has the same position as for position 0 in the unpatched Office. Test looks then, that the bound rectangle is correct.

You can see the Cppunit test code in https://gerrit.libreoffice.org/c/core/+/123997. In case you can use it, you can of cause take all of it under Apache License 2.0 too.

I will attach the file and a screenshot, how it should look.
Comment 3 Regina Henschel 2021-10-23 00:18:57 UTC 
Created attachment 87063 [details]
Screenshot how it should be rendered
Comment 4 Regina Henschel 2021-10-23 00:21:17 UTC 
Created attachment 87064 [details]
File from which the screenshot is taken.

The file source is manually changed to have the different depth positions. There exist no UI to set the depth position.
Comment 5 Matthias Seidel 2021-11-02 18:26:57 UTC 
Created Pull Request:

https://github.com/apache/openoffice/pull/140

Many thanks Regina!
Comment 7 Matthias Seidel 2021-11-08 20:56:41 UTC 
See:

https://home.apache.org/~mseidel/AOO-builds/AOO-4112-Test/

for Windows Test Builds.