Issue 14307 - Parallel build fails making resource files: SRS dependency lost
Summary: Parallel build fails making resource files: SRS dependency lost
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: code (show other issues)
Version: OOo 1.1 Beta2
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 1.1 RC
Assignee: hjs
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks: 9443
  Show dependency tree
 
Reported: 2003-05-09 18:30 UTC by chris
Modified: 2003-06-12 11:46 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
add those lines to failing makefile (413 bytes, text/plain)
2003-05-13 12:45 UTC, hjs 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description chris 2003-05-09 18:30:10 UTC 
Uh oh ause look out, haggai's back hunting parallel failures :)

Here's a typical build failure:

In offmgr/source/offapp/intro:

Preprocessor commandline:  -I../../../unxlngi4.pro/res/34
-I../../../unxlngi4.pro/res/49 -I../../../unx/res -I../../../res
-I../../../win/res -I../../../../res -I../../../win/res;../../../RES
-I/oo/openoffice.org1.1-1.1beta1.prebeta2/build-tree/oo_1.1beta1.prebeta2_src
-I../../../inc -I.
-I/oo/openoffice.org1.1-1.1beta1.prebeta2/build-tree/oo_1.1beta1.prebeta2_src/solver/644/unxlngi4.pro/inc/stl
-I/oo/openoffice.org1.1-1.1beta1.prebeta2/build-tree/oo_1.1beta1.prebeta2_src/solver/644/unxlngi4.pro/inc/external
-I/oo/openoffice.org1.1-1.1beta1.prebeta2/build-tree/oo_1.1beta1.prebeta2_src/solver/644/unxlngi4.pro/inc
-I/oo/openoffice.org1.1-1.1beta1.prebeta2/build-tree/oo_1.1beta1.prebeta2_src/solenv/unxlngi4/inc
-I/oo/openoffice.org1.1-1.1beta1.prebeta2/build-tree/oo_1.1beta1.prebeta2_src/solenv/inc
-I/oo/openoffice.org1.1-1.1beta1.prebeta2/build-tree/oo_1.1beta1.prebeta2_src/res
-I/oo/openoffice.org1.1-1.1beta1.prebeta2/build-tree/oo_1.1beta1.prebeta2_src/solver/644/unxlngi4.pro/inc/stl
-I/oo/openoffice.org1.1-1.1beta1.prebeta2/build-tree/oo_1.1beta1.prebeta2_src/solenv/inc/Xp31
-I/usr/lib/j2sdk1.3/include -I/usr/lib/j2sdk1.3/include/linux
-I/usr/lib/j2sdk1.3/include/native_threads/include -I/usr/X11R6/include
../../../unxlngi4.pro/srs/ooo.srs /tmp/fileVAF0BA
Preprocessor startline:  rscpp @/tmp/fileGbqe50
Files: /tmp/fileAm9wZ1
reading file /tmp/fileAm9wZ1 .............

f258: Error: This file <lo_files.bmp> cannot be opened.
Terminating compiler
Error starting rsc2 compiler
dmake:  Error code 1, while making '../../../unxlngi4.pro/bin/ooo64449.res'

The failure is happening because the RESLIBxTARGETN files do not depend on
RESLIBxSRSFILES any more.  This is because the dependency rule only works in a
submake.  Extracts from tg_rslb.mak:

$(RESLIB1TARGETN) .NULL : RESLIB1
RESLIB1 RESLIB2 RESLIB3 RESLIB4 RESLIB5 RESLIB6 RESLIB7 RESLIB8 RESLIB9:
        @dmake $(RESLIB$(TNR)TARGETN) solarlang=$(solarlang)
MULTI_RESLIB_FLAG=true TNR:=$(TNR) $(MFLAGS) $(CALLMACROS)

$(RESLIB$(TNR)TARGETN): \
                $(RESLIB$(TNR)SRSFILES) \
                $(RESLIB$(TNR)BMPS)

See what I mean?  I think you'll have to unroll those dependencies manually somehow.
Comment 1 chris 2003-05-09 18:37:36 UTC 
Hmm, funny thing is, it seems to work in offapp/app.  So is there
something else I missed?

To reproduce:

cd offmgr/unxlngi4.pro; rm srs/*; rm -r res/*; cd
../source/offapp/intro  ; dmake -P4
Comment 2 hjs 2003-05-13 12:40:40 UTC 
it's a missing dependency. the resource libraries (*.res) do not
depend on the generated bitmaps. this only shows up when both are
targets in the same makefile.
i'll fix this in "target.mk". for now add the lines in the attachment
to the end of "offmgr/source/offapp/intro/makefile.mk".
Comment 3 hjs 2003-05-13 12:45:46 UTC 
Created attachment 6179 [details]
add those lines to failing makefile
Comment 4 hjs 2003-05-27 12:11:06 UTC 
inserted dependency to "solenv/inc/target.mk"
Comment 5 gregor.hartmann 2003-06-02 13:47:46 UTC 
reviewed
Comment 6 hjs 2003-06-02 15:16:39 UTC 
build environment issue.
Comment 7 hjs 2003-06-12 11:46:52 UTC 
ooo11rc will contain the fixes