Issue 14319 - .NET build fails in setup2/win/source/loader
Summary: .NET build fails in setup2/win/source/loader
Status: CLOSED FIXED
Alias: None
Product: Installation
Classification: Application
Component: code (show other issues)
Version: OOo 1.1 Beta2
Hardware: PC Windows 2000
: P3 Trivial (vote)
Target Milestone: OOo 1.1 RC
Assignee: oliver.bolte
QA Contact: issues@installation
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-05-10 09:47 UTC by quetschke
Modified: 2003-09-08 16:53 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Patch for external (1.72 KB, patch)
2003-05-18 15:57 UTC, quetschke 		no flags Details | Diff
Patch for dtrans (572 bytes, patch)
2003-05-18 15:58 UTC, quetschke 		no flags Details | Diff
Patch for embedserv (548 bytes, patch)
2003-05-18 15:59 UTC, quetschke 		no flags Details | Diff
Patch for extensions (3.01 KB, patch)
2003-05-18 16:00 UTC, quetschke 		no flags Details | Diff
Patch for setup2 (625 bytes, patch)
2003-05-18 16:01 UTC, quetschke 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description quetschke 2003-05-10 09:47:02 UTC 
The build with .NET fails in setup2/win/source/loader because
MS moved the winres.h out of the compiler standard include directory.

As a workaround I copied the file from

.../...NET/Vc7/atlmfc/include/winres.h to solver/inc

Errorlog:
------------------------------
Making: ../../../wntmsci8.pro/res/01/loader.res
guw.pl rc -I.  -I. -I../inc -I../../../inc -I../../../WIN/inc
-I../../../wntmsci8.pro/inc -I.
-I/v1/cws_srx644_ooo11beta2cyg/solver/644/wntmsci8.pro/inc/stl
-I/v1/cws_srx644_ooo11beta2cyg/solver/644/wntmsci8.pro/inc/external
-I/v1/cws_srx644_ooo11beta2cyg/solver/644/wntmsci8.pro/inc
-I/v1/cws_srx644_ooo11beta2cyg/solenv/wntmsci8/inc
-I/v1/cws_srx644_ooo11beta2cyg/solenv/inc -I/v1/cws_srx644_ooo11beta2cyg/res
-I/v1/cws_srx644_ooo11beta2cyg/solver/644/wntmsci8.pro/inc/stl
-I/cygdrive/c/j2sdk1.4.1_02/include/win32 -I/cygdrive/c/j2sdk1.4.1_02/include
-I'/cygdrive/C/Programme/Microsoft SDK/include'
-I/cygdrive/c/PROGRA~1/MICROS~1.NET/Vc7/include     -I. -I../../../res -I.
-I/v1/cws_srx644_ooo11beta2cyg/solver/644/wntmsci8.pro/res -d ENGLISH -r -DWIN32
-fo../../../wntmsci8.pro/res/01/loader.res loader.rc
Command: rc
loader.rc(1) : fatal error RC1015: cannot open include file 'winres.h'.
dmake:  Error code 1, while making '../../../wntmsci8.pro/res/01/loader.res'
echo: No match.

ERROR: Error 65280 occurred while making
/v1/cws_srx644_ooo11beta2cyg/setup2/win/source/loader
dmake:  Error code 1, while making 'build_all'
echo: No match.
Comment 1 quetschke 2003-05-10 09:49:20 UTC 
Change target
Comment 2 Olaf Felka 2003-05-12 15:17:39 UTC 
Hi Oliver,
is this issue related to 14321?
Comment 3 oliver.bolte 2003-05-14 09:31:54 UTC 
This issue will be fixed together with i14321
Comment 4 quetschke 2003-05-18 15:56:45 UTC 
Hi Oliver, as you already closed iz 14321 I will attach my patches to
this issue.

The following patches do:

- Remove external/atl from the build/deliver in external. It's
  not needed anymore and can be removed. (atl_external.diff)
- Convert every occurence of $(SOLARINCDIR)$/external$/atl to
  $(ATL_INCLUDE) in the cws_srx644_obo02 tree.
  (atl_dtrans.diff, atl_embedserv.diff, atl_extensions.diff)

- Add INCPOST+=$(ATL_INCLUDE) to setup2/win/source/loader/makefile.mk.
  This solves this issue for me, but you already mentioned possible
  problems with the WINVER. So this patch (atl_setup2.diff) should
  be reviewed carefully.

With this patches applied I did a succesful build with MSVC6, PSDK
02/2003.

Volker
Comment 5 quetschke 2003-05-18 15:57:58 UTC 
Created attachment 6257 [details]
Patch for external
Comment 6 quetschke 2003-05-18 15:58:37 UTC 
Created attachment 6258 [details]
Patch for dtrans
Comment 7 quetschke 2003-05-18 15:59:15 UTC 
Created attachment 6259 [details]
Patch for embedserv
Comment 8 quetschke 2003-05-18 16:00:07 UTC 
Created attachment 6260 [details]
Patch for extensions
Comment 9 quetschke 2003-05-18 16:01:20 UTC 
Created attachment 6261 [details]
Patch for setup2
Comment 10 oliver.bolte 2003-05-20 15:43:59 UTC 
The changes are commited for cws_srx644_obo02.

Fix for winres.h made in solenv/inc/tg_res.mk.
Comment 11 rt 2003-05-20 16:07:06 UTC 
RT: I reviewed your changes in tg_res.mk and wnt.mk. Looks good for me.
Comment 12 oliver.bolte 2003-05-21 15:25:02 UTC 
.
Comment 13 oliver.bolte 2003-06-05 16:14:58 UTC 
.