Issue 14355 - Regression beta1->2: cde Maths icons missing
Summary: Regression beta1->2: cde Maths icons missing
Status: CLOSED FIXED
Alias: None
Product: Installation
Classification: Application
Component: code (show other issues)
Version: OOo 1.1 Beta2
Hardware: All All
: P4 Trivial (vote)
Target Milestone: OOo 1.1 RC
Assignee: Olaf Felka
QA Contact: issues@installation
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-05-12 11:29 UTC by chris
Modified: 2003-09-08 16:53 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description chris 2003-05-12 11:29:18 UTC 
I suspect this may have been caused by changes made for Issue 4238?

cdemath.zip is created in sysui but is never packed into the installation set
and therefore the Maths icons for CDE are missing.  I suspect this is because
there is no entry for cdemath.zip in files_cde.scp?
Comment 1 Olaf Felka 2003-05-12 12:12:24 UTC 
Hi Martin,
any idea?
Comment 2 nospam4obr 2003-05-12 15:11:36 UTC 
I probably missed that one when joining scp_so/source/cde and
scp/source/oocde. 

Nevertheless I think the files contained in cdemath.zip should be
included in cdewriter.zip, since math is not a standalone module (i.e.
can not be deselected during setup). 

This way we can avoid multiple "#ifdef OSL_PRODUCT" in scp because SO
doesn't have this math launcher.
Comment 3 robert.kinsella 2003-05-14 11:10:35 UTC 
setting target to 1.1
Comment 4 Martin Hollmichel 2003-05-15 15:08:07 UTC 
reassigned and retargeted
Comment 5 nospam4obr 2003-05-19 14:35:56 UTC 
Since beta 2 went out without this fix, I am adjusting the priority.
Comment 6 khendricks 2003-05-19 15:19:47 UTC 
Hi, 
 
I looked and sysui/oounix/office/cde seems to be doing the right thing here. 
 
So the problem is in scp/source/cde/files_cde.scp 
 
It seems to be missing the following snippet  
 
File GID_FILE_EXTRA_CDEMATH 
        Dir             = GID_DIR_CDE_NETDIR; 
        TXT_FILE_BODY; 
        Styles = (ARCHIVE,SUBSTITUTE); 
        Name = "cdemath.zip"; 
End 
 
I am not sure but adding this piece might do the trick unless math has 
been left out someplace else (cdeint or dtintegrate.sh?). 
 
Kevin
Comment 7 nospam4obr 2003-05-20 06:17:51 UTC 
Hi Kevin,

if you want to add this snippet into files_cde.scp, make sure to
encapsulate it into an "#ifdef OSL_PRODUCT": StarOffice does not have
a cdemath.zip !

As I said, the other option would be to add the files from cdemath.zip
to cdewriter.zip and we were done as well.

What do you prefer ?
Comment 8 nospam4obr 2003-05-21 14:43:30 UTC 
Ingo, could you please re-add cdemath.zip for OOo only (the #ifdef
OSL_PRODUCT solution) ? Thanks.
Comment 9 ingo.schmidt-rosbiegal 2003-05-22 11:17:13 UTC 
I added the file definition into files_cde.scp

#ifdef OSL_PRODUCT

File GID_FILE_EXTRA_CDEMATH 
        Dir             = GID_DIR_CDE_NETDIR; 
        TXT_FILE_BODY; 
        Styles = (ARCHIVE,SUBSTITUTE); 
        Name = "cdemath.zip"; 
End 

#endif

The file is only added for OpenOffice.org and belongs to the module
GID_MODULE_PRG_MATH_BIN in module_math.scp.

  Ingo
Comment 10 ingo.schmidt-rosbiegal 2003-06-02 11:51:26 UTC 
Olaf, I created an installation set in cws setup10. You find this at:
instset/unxsols4.pro/openoffice.
Unfortunately there are many missing files. Therefore you have to
ignore some mistakes during the installation. And also the basic
script errors and the errors during component registration must be
ignored. Furthermore I added the StarOffice readme and license files
by hand to make this installation set installable.  
But the files from cdemath.zip are installed correctly. Therefore this
bug is fixed.
Comment 11 ingo.schmidt-rosbiegal 2003-06-02 11:53:12 UTC 
reopen again
Comment 12 ingo.schmidt-rosbiegal 2003-06-02 11:53:40 UTC 
... and reassign to you.
Comment 13 Olaf Felka 2003-06-02 14:28:21 UTC 
Looks good for me in cws setup10.
Comment 14 Olaf Felka 2003-06-02 14:28:41 UTC 
Verified.
Comment 15 robert.kinsella 2003-06-24 13:09:27 UTC 
verified fixed on 1.1rc builda - closing issue