Issue 14733 - Compile Error with gcc2 in sfx2/source/dialog/filedlghelper.cxx due to missing cast
Summary: Compile Error with gcc2 in sfx2/source/dialog/filedlghelper.cxx due to missin...
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: OOo 1.1 Beta2
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 1.1 RC
Assignee: nickb
QA Contact: issues@framework
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-05-22 08:05 UTC by Unknown
Modified: 2004-02-15 07:20 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Unknown 2003-05-22 08:05:47 UTC 
As the subject says, there is a problem compiling this file with gcc2.
Adding a simple cast resolves the issue:

--- sfx2/source/dialog/filedlghelper.cxx	4 Apr 2003 18:06:00 -0000	1.102
+++ sfx2/source/dialog/filedlghelper.cxx	20 May 2003 05:53:37 -0000
@@ -657,7 +657,7 @@
 		( mbSelectionEnabled && pFilter && ( pFilter->GetFilterFlags() &
SFX_FILTER_SUPPORTSSELECTION ) != 0 ) );
 
 	Reference< XFilePickerControlAccess > xCtrlAccess( mxFileDlg, UNO_QUERY );
-	xCtrlAccess->setValue( ExtendedFilePickerElementIds::CHECKBOX_SELECTION, 0,
makeAny( mbSelection ) );
+	xCtrlAccess->setValue( ExtendedFilePickerElementIds::CHECKBOX_SELECTION, 0,
makeAny( (sal_Bool)mbSelection ) );
 }
 
 // ------------------------------------------------------------------------
Comment 1 Unknown 2003-05-22 08:06:13 UTC 
accepting issue
Comment 2 Unknown 2003-05-22 08:08:37 UTC 
Also in sfx2/source/doc/sfxbasemodel.cxx
This cast was here previously, but removed for some reason.

--- sfx2/source/doc/sfxbasemodel.cxx	5 May 2003 16:27:50 -0000	1.48
+++ sfx2/source/doc/sfxbasemodel.cxx	20 May 2003 06:09:48 -0000
@@ -2461,12 +2461,12 @@
 
 SfxObjectShell* SfxBaseModel::GetObjectShell() const
 {
-	return m_pData ? m_pData->m_pObjectShell : 0;
+	return m_pData ? (SfxObjectShell*) m_pData->m_pObjectShell : 0;
 }
 
 SfxObjectShell* SfxBaseModel::impl_getObjectShell() const
 {
-	return m_pData ? m_pData->m_pObjectShell : 0;
+	return m_pData ? (SfxObjectShell*) m_pData->m_pObjectShell : 0;
 }
 
 //________________________________________________________________________________________________________
Comment 3 Unknown 2003-05-23 07:41:29 UTC 
also in:

--- sfx2/source/bastyp/progress.cxx	27 Mar 2003 11:27:50 -0000	1.13
+++ sfx2/source/bastyp/progress.cxx	20 May 2003 04:27:19 -0000
@@ -216,7 +216,7 @@
 
 void SfxProgress_Impl::Enable_Impl( BOOL bEnable )
 {
-    SfxObjectShell* pDoc = bAllDocs ? NULL : xObjSh;
+    SfxObjectShell* pDoc = bAllDocs ? NULL : (SfxObjectShell*) xObjSh;
 	SfxViewFrame *pFrame= SfxViewFrame::GetFirst(pDoc);
 	while ( pFrame )
 	{
Comment 4 Unknown 2003-06-16 05:20:04 UTC 
re-assigning to Nick Blievers
Comment 5 Martin Hollmichel 2003-07-04 10:56:34 UTC 
set target milestone
Comment 6 Martin Hollmichel 2003-07-14 17:17:01 UTC 
i think these patches are already applied.
Comment 7 Martin Hollmichel 2004-02-15 07:19:51 UTC 
mark as verified
Comment 8 Martin Hollmichel 2004-02-15 07:20:35 UTC 
close issue.