Issue 14771 - IRIX Port: dmake fails to build on 1.1 beta 2
Summary: IRIX Port: dmake fails to build on 1.1 beta 2
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: code (show other issues)
Version: OOo 1.1 Beta2
Hardware: SGI IRIX
: P2 Trivial (vote)
Target Milestone: ---
Assignee: foskey
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-05-23 03:32 UTC by Unknown
Modified: 2003-05-26 02:26 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
dmake/unix/sysvr4/public.h (452 bytes, patch)
2003-05-23 04:34 UTC, Unknown 		no flags Details | Diff
This is a complete patch for this problem on ALL public files, check and approve. (19.12 KB, patch)
2003-05-24 13:14 UTC, foskey 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Unknown 2003-05-23 03:32:12 UTC 
Someone has changed the return type of main in dmake.c to int from void, but the
header file IRIX uses still had the old definition of main with the return type
of void.

Line 91 of dmake/unix/sysvr4/public.h was:
void main ANSI((int, char **));

and should be:
int main ANSI((int, char **));

in order for IRIX to compile dmake.
Comment 1 Unknown 2003-05-23 03:32:34 UTC 
accepting issue
Comment 2 foskey 2003-05-23 03:38:37 UTC 
Taking issue...
Comment 3 Unknown 2003-05-23 04:33:01 UTC 
Hey Ken,
I actually have a patch for this, and was planning on checking it in
soon. If you would like to do it however, I'll post my patch (as
trivial as it may be :-) )

George
Comment 4 Unknown 2003-05-23 04:34:15 UTC 
Created attachment 6342 [details]
dmake/unix/sysvr4/public.h
Comment 5 foskey 2003-05-24 13:14:14 UTC 
Created attachment 6379 [details]
This is a complete patch for this problem on ALL public files,  check and approve.
Comment 6 foskey 2003-05-24 13:18:06 UTC 
Committed the IRIX specific patch.  Waing approval of the others to
apply and close.
Comment 7 quetschke 2003-05-24 13:50:35 UTC 
Ken, there are mac, qssl ?!, tos, OS/2 and many DOS/windows
compilers involved. I think most of them haven't been used
to compile dmake in a long time.

As main() changed from void to int, it should be
save to change the declaration for all remaining architectures.

Despite the one solaris and maybe some bsd's none of these architectures
is actually used to build OOo, so maybe your patch fixes a warning for
them. I'd say go!

At least it's save for me to say GO for all DOS/Windows and OS/2
targets. :-)
Also GO for tos. I'd really like to see someone complaining that his
OOo build broke on his Atari TT due to your change to dmake.
Comment 8 foskey 2003-05-24 13:58:32 UTC 
Applied patches, no matter how unlikely to be hit.  I never want to
see this problem again.

George please verify and close.
Comment 9 Unknown 2003-05-26 02:26:25 UTC 
patch verified, thanks Ken.
Comment 10 Unknown 2003-05-26 02:26:37 UTC 
closing issue