Issue 14776 - IRIX port: putc overloaded in filter/source/placeware/zip.cxx
Summary: IRIX port: putc overloaded in filter/source/placeware/zip.cxx
Status: CLOSED FIXED
Alias: None
Product: porting
Classification: Code
Component: code (show other issues)
Version: OOo 1.1 Beta2
Hardware: SGI IRIX
: P2 Trivial (vote)
Target Milestone: OOo 1.1 RC
Assignee: nickb
QA Contact: issues@porting
URL:
Keywords: merge_pending
Depends on:
Blocks:
 
Reported: 2003-05-23 05:37 UTC by Unknown
Modified: 2004-02-15 07:20 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
filter/source/placeware/zip.cxx (1.28 KB, patch)
2003-05-23 05:39 UTC, Unknown 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Unknown 2003-05-23 05:37:18 UTC 
In filter/source/placeware/zip.cxx, putc has been overloaded.
On some platforms this may work fine, but on Irix putc is macro.
eg: #define putc(i) fputc(stdout, i)

The overloaded funtion will cause compile erros on Irix.
One solution is to #undef putc in this file, but I dont like this approach as it
is very messy, and bad coding. The best thing would be to rename the overloaded
funtion to say putC.
Comment 1 Unknown 2003-05-23 05:38:53 UTC 
accepting issue
Comment 2 Unknown 2003-05-23 05:39:45 UTC 
Created attachment 6343 [details]
filter/source/placeware/zip.cxx
Comment 3 Unknown 2003-05-23 05:40:32 UTC 
added keyword
Comment 4 khendricks 2003-06-06 13:59:14 UTC 
Hi George, 
 
This looks fine to me.  Since the original putc implementation was "static" its scope 
was only inside that file and since no header contains that function and since no  
predeclartion needed (since the defintion came first) your change should be fine. 
 
approved 
 
Kevin
Comment 5 Unknown 2003-06-16 05:20:40 UTC 
re-assigning to Nick Blievers
Comment 6 Martin Hollmichel 2003-06-16 11:32:02 UTC 
retarget.
Comment 7 nickb 2003-07-04 02:24:07 UTC 
Checked into cws_srx645_ooo11rc
Comment 8 Martin Hollmichel 2004-02-15 07:19:54 UTC 
mark as verified
Comment 9 Martin Hollmichel 2004-02-15 07:20:37 UTC 
close issue.