Issue 15335 - crash with -nogui (patch)
Summary: crash with -nogui (patch)
Status: CLOSED FIXED
Alias: None
Product: Installation
Classification: Application
Component: code (show other issues)
Version: OOo 1.1 Beta2
Hardware: PC Linux, all
: P2 Trivial (vote)
Target Milestone: OOo 1.1 RC
Assignee: Olaf Felka
QA Contact: issues@installation
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-06-05 15:43 UTC by mmeeks
Modified: 2003-09-08 16:53 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description mmeeks 2003-06-05 15:43:36 UTC
When you run with -nogui you get a nice SEGV - this (trivial) patch fragment
fixes it - nice to have the -nogui option in there though; extremely useful.
Thanks:

--- setup2/source/agenda/agenda.cxx     15 May 2003 09:39:26 -0000      1.80
+++ setup2/source/agenda/agenda.cxx     5 Jun 2003 13:45:41 -0000
@@ -2102,14 +2102,18 @@ void SiAgenda::PrintFoot(int nErrors)
 
 void SiAgenda::UpdateATToolSupport()
 {
-    AllSettings  aAllSettings( Application::GetSettings() );
-    MiscSettings aMiscSettings( aAllSettings.GetMiscSettings() );
+       AllSettings  aAllSettings( Application::GetSettings() );
+       MiscSettings aMiscSettings( aAllSettings.GetMiscSettings() );
 
-    // now we get the ATTool Settings
-       BOOL bEnable = aMiscSettings.GetEnableATToolSupport();
+       // now we get the ATTool Settings
+       BOOL bEnable;
+       if( m_pEnv->HasVCL() )
+               bEnable = aMiscSettings.GetEnableATToolSupport();
+       else
+               bEnable = FALSE;
        m_pEnv->SetATToolSupport( bEnable );
 
-    // and finaly change the Replacement
-    m_pEnv->UpdateReplacement( "<ATToolSupport>", m_pEnv->GetATToolSupport() );
+       // and finaly change the Replacement
+       m_pEnv->UpdateReplacement( "<ATToolSupport>", m_pEnv->GetATToolSupport() );
 }
Comment 1 Olaf Felka 2003-06-05 15:47:50 UTC
Hi Dirk,
please have a look at the patch.
Comment 2 dirk.voelzke 2003-06-10 09:23:39 UTC
fixed in cws srx645 vcl12
Comment 3 philipp.lohmann 2003-06-10 16:26:34 UTC
pl->of: patch should be applied in vcl12, please have a look
Comment 4 Olaf Felka 2003-06-11 12:41:04 UTC
The patch is integrated in this cws. 
Comment 5 Olaf Felka 2003-06-11 12:41:22 UTC
Verified
Comment 6 Olaf Felka 2003-07-01 12:21:34 UTC
No crash in 1.1 RC.