Issue 15556 - Trivial patches For FreeBSD
Summary: Trivial patches For FreeBSD
Status: CLOSED FIXED
Alias: None
Product: porting
Classification: Code
Component: code (show other issues)
Version: OOo 1.1 Beta2
Hardware: Other FreeBSD
: P3 Trivial (vote)
Target Milestone: ---
Assignee: Martin Hollmichel
QA Contact: issues@porting
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-06-12 14:10 UTC by maho.nakata
Modified: 2003-11-05 08:27 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
quite trivial patches for FreeBSD (1.84 KB, application/octet-stream)
2003-06-12 14:12 UTC, maho.nakata 		no flags Details
Ifdef'ed (276 bytes, patch)
2003-06-12 15:47 UTC, maho.nakata 		no flags Details | Diff
new file (provided as patch) solenv+inc+startup+FREEBSD+macros.mk (197 bytes, patch)
2003-06-12 23:00 UTC, maho.nakata 		no flags Details | Diff
Renew sal+osl+unx+system.c (1.77 KB, patch)
2003-06-12 23:21 UTC, maho.nakata 		no flags Details | Diff
Please use this newer one instead. Very sorry... (1.19 KB, patch)
2003-06-12 23:40 UTC, maho.nakata 		no flags Details | Diff
patches for sal/osl/unx/system.h (1.87 KB, patch)
2003-06-14 03:37 UTC, maho.nakata 		no flags Details | Diff
Added FreeBSD's definition for DESTDIRBIN. (407 bytes, patch)
2003-06-15 09:44 UTC, maho.nakata 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description maho.nakata 2003-06-12 14:10:26 UTC 
Quite trivial patches for FreeBSD.
Made by Martin Blapp.
please apply.

patch-sal+osl+unx+system.c                      patch-soltools+mkdepend+main.c
patch-sal+textenc+tencinfo.c                   
patch-tools+source+string+tstring.cxx
patch-solenv+inc+startup+FREEBSD+macros.mk      patch-unoil+makefile.pmk
Comment 1 maho.nakata 2003-06-12 14:12:15 UTC 
Created attachment 6823 [details]
quite trivial patches for FreeBSD
Comment 2 sander_traveling 2003-06-12 15:08:59 UTC 
patch-soltools+mkdepend+main.c - this was rejected, the addition of
headers should be if-defed

patch-tools+source+string+tstring.cxx - this was rejected, it just
covers up bugs in teh rest of teh codebase and should not be used

patch-solenv+inc+startup+FREEBSD+macros.mk - this has already been applied

patch-sal+textenc+tencinfo.c - not ifdefed and very unclear why its
needed on freebsd and how it affects other platforms
Comment 3 maho.nakata 2003-06-12 15:47:46 UTC 
Created attachment 6826 [details]
Ifdef'ed
Comment 4 maho.nakata 2003-06-12 15:48:40 UTC 
Hi, Sander, thanks for your very fast reply.
I remade 
patch-soltools+mkdepend+main.c
as you suggested, ifdef'ed.
Comment 5 maho.nakata 2003-06-12 15:56:17 UTC 
Hi, sander,
How about patch-sal+osl+unx+system.c?
would you please consider to apply this?
Comment 6 maho.nakata 2003-06-12 22:59:06 UTC 
Hi Sander,

patch-solenv+inc+startup+FREEBSD+macros.mk
is not applied.
Please apply!
Thanks for your time, and anxiety for your hard work.
Comment 7 maho.nakata 2003-06-12 23:00:56 UTC 
Created attachment 6835 [details]
new file (provided as patch) solenv+inc+startup+FREEBSD+macros.mk
Comment 8 maho.nakata 2003-06-12 23:07:04 UTC 
You can find patch-solenv+inc+startup+FREEBSD+macros.mk
at patches.tar.gz but for your convinience, I attached
separately.

Thanks,
 Maho
Comment 9 maho.nakata 2003-06-12 23:21:05 UTC 
Created attachment 6836 [details]
Renew sal+osl+unx+system.c
Comment 10 maho.nakata 2003-06-12 23:24:08 UTC 
I remade patch-sal+osl+unx+system.c to compile correctly.
line 76 of sal/osl/unx/system.c, it reads:
/* struct passwd differs on some platforms */
However it does not applies for recent FreeBSD.
my patch is intended to 5.1-CURRENT, and it is ok to
rewrote at ports level (so it is not related to you)

Please apply.
Thanks.
Comment 11 maho.nakata 2003-06-12 23:40:14 UTC 
Created attachment 6837 [details]
Please use this newer one instead. Very sorry...
Comment 12 fa 2003-06-14 03:10:22 UTC 
FWIW, I have looked these over and they appear FreeBSD specific.  I approve:

patch-soltools+mkdepend+main.c
patch-solenv+inc+startup+FREEBSD+macros.mk (if not already applied)
patch-sal+osl+unx+system.c  (2003-06-12 15:40)

Dan
Comment 13 maho.nakata 2003-06-14 03:35:34 UTC 
Huge thanks Dan, for your time and kindness.
I also attach 
patch-sal+osl+unx+system.h

this patch is a some changes of header, definitions
and *DO NOT* affect other systems since
patch is inside of #if defined (FREEBSD) -- #endif
Comment 14 maho.nakata 2003-06-14 03:37:54 UTC 
Created attachment 6865 [details]
patches for sal/osl/unx/system.h
Comment 15 maho.nakata 2003-06-15 09:43:25 UTC 
Added patch-odk+util+makefile.pmk
without it, 
when building project odk, cppumaker will be copied root
directory.(this patch is written by me)
Comment 16 maho.nakata 2003-06-15 09:44:40 UTC 
Created attachment 6890 [details]
Added FreeBSD's definition for DESTDIRBIN.
Comment 17 fa 2003-06-15 22:53:52 UTC 
Hi,

these patches have been committed to cws_srx644_ooo11beta2:
patch-solenv+inc+startup+FREEBSD+macros.mk
patch-soltools+mkdepend+main.c
patch-sal+osl+unx+system.c  (2003-06-12 15:40)
patch-sal+osl+unx+system.h

Dan
Comment 18 maho.nakata 2003-06-15 22:58:52 UTC 
Thanks, Dan.
For your kindness, time, and effort...

--maho
Comment 19 dankegel 2003-06-17 14:30:48 UTC 
Shouldn't the status of this bug be marked STARTED or RESOLVED/Worksforme?
Comment 20 maho.nakata 2003-06-19 12:56:32 UTC 
Hi, Dan Kegel,
As you told me, I set the status to STARTED.
Comment 21 maho.nakata 2003-06-19 13:09:16 UTC 
Failed. Sorry.
Comment 22 maho.nakata 2003-06-22 16:00:32 UTC 
Hi Folks, 
I'll remake for cws_srx645_ooo11rc. So I close this issue.
Thanks for reviewing our patches.
--maho
Comment 23 maho.nakata 2003-11-05 08:25:08 UTC 
closing
Comment 24 maho.nakata 2003-11-05 08:27:10 UTC 
closing...